Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dimensions modification bug #358

Merged
merged 4 commits into from Sep 4, 2020
Merged

Fix dimensions modification bug #358

merged 4 commits into from Sep 4, 2020

Conversation

Jedi18
Copy link
Contributor

@Jedi18 Jedi18 commented Aug 26, 2020

Closes #238 , the new modified dimension dind't have the same entity id set because of which it wasn't removed in the insertEntity function and hence the old copy persisted.

Closes #237 , implemented bounding box functions for the dimensions.

@feragon feragon merged commit b6d7449 into LibreCAD:master Sep 4, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants