Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lirc: simplify scripts #1295

Merged
merged 1 commit into from Feb 9, 2017

Conversation

Projects
None yet
5 participants
@lrusak
Copy link
Member

commented Feb 8, 2017

would someone with some sanity left please test this.

@MilhouseVH ?

It seems to work fine on my WeTek Hub

@lrusak lrusak added the BUGFIX label Feb 8, 2017

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Feb 8, 2017

I don't think I'm able to test LIRC

@lrusak lrusak force-pushed the lrusak:lirc branch from 44e894d to 64a31b5 Feb 8, 2017

@lrusak

This comment has been minimized.

Copy link
Member Author

commented Feb 8, 2017

So incase people are wondering this basically lets the lirc_helper script run lircd-uinput after lircd. This way we don't have any systemd dependency issues.

I have also added some log messages if lirc fails to run (because of a missing lircd.conf file)

Feb 07 23:26:16 LibreELEC lircd_helper[3885]: No device specific lircd.conf.amremote file found
Feb 07 23:26:16 LibreELEC lircd_helper[3885]: You need to provide your own lircd.conf.amremote file
Feb 07 23:26:16 LibreELEC lircd_helper[3885]: Place it in /storage/.config/lircd.conf.amremote

So now people can check the journal to see why lircd isn't running.

@InuSasha

This comment has been minimized.

Copy link
Member

commented Feb 8, 2017

@lrusak I made a simple test on RPi2 with lirc-rpi overlay.
Remote was correctly detected and is running, without problems.
here the journal-log: http://sprunge.us/AIZU

@HiassofT

This comment has been minimized.

Copy link
Member

commented Feb 8, 2017

I ran some quick tests on my RPi2, lirc_rpi, gpio_ir with lircd.conf, lirc_rpi+gpio_ir with and without lircd.conf and so far everything seems to startup fine.

Thanks!

@lrusak

This comment has been minimized.

Copy link
Member Author

commented Feb 8, 2017

looks good 👍

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Feb 9, 2017

Included in tonight's #208 RPi/RPi2 and Generic test builds.

@chewitt

chewitt approved these changes Feb 9, 2017

Copy link
Member

left a comment

Pulling this in to get it into beta builds for testing.

@chewitt chewitt merged commit fced1db into LibreELEC:master Feb 9, 2017

chewitt added a commit that referenced this pull request Feb 9, 2017

Merge pull request #1305 from lrusak/lirc-libreelec-8.0
backport of #1295 (lirc: simplify scripts)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.