Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build system scripts cleanup #1326

Merged
merged 4 commits into from Feb 26, 2017

Conversation

@MilhouseVH
Copy link
Contributor

commented Feb 12, 2017

skip_unpack is obsolete and no longer serves any purpose.

The get patch may look scary but it's really just a case of moving code around to avoid taking the lock unless we really need to download something, and then removing a couple of mass deletes (rm -f $BUILD_BASE*/$STAMPS_NOARCH/$1/[build|unpack]) that also have no purpose.

Edit: And the md5sum calculation is dropped from get as it's utterly pointless.

@MilhouseVH MilhouseVH changed the title Script cleanup Build system scripts cleanup Feb 12, 2017

@MilhouseVH MilhouseVH force-pushed the MilhouseVH:script_cleanup branch from a97dcdc to 30d6ee7 Feb 12, 2017

@lrusak

This comment has been minimized.

Copy link
Member

commented Feb 12, 2017

LGTM 👍

@MilhouseVH MilhouseVH force-pushed the MilhouseVH:script_cleanup branch from 30d6ee7 to 03363dc Feb 12, 2017

@MilhouseVH

This comment has been minimized.

Copy link
Contributor Author

commented Feb 12, 2017

Added an extra get commit to silence messages such as the following:

wget: /home/neil/projects/LibreELEC.tv/build.LibreELEC-RPi.arm-9.0-devel/toolchain/lib/libcrypto.so.1.0.0: no version information available (required by wget)
wget: /home/neil/projects/LibreELEC.tv/build.LibreELEC-RPi.arm-9.0-devel/toolchain/lib/libssl.so.1.0.0: no version information available (required by wget)
wget: /home/neil/projects/LibreELEC.tv/build.LibreELEC-RPi.arm-9.0-devel/toolchain/lib/libssl.so.1.0.0: no version information available (required by wget)

that appear when building with OpenSSL (#1312) as the host binary (ie. wget) is loading shared libraries from toolchain/lib rather than the host /lib/x86_64-linux-gnu (on Ubuntu 16.04), thanks to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.