Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input: change input repeat config #1327

Merged
merged 2 commits into from Feb 18, 2017

Conversation

@Kwiboo
Copy link
Contributor

commented Feb 12, 2017

Same as #1323 but for master

@lrusak

This comment has been minimized.

Copy link
Member

commented Feb 12, 2017

Seems to work as intended 👍

@Kwiboo Kwiboo force-pushed the Kwiboo:master-lirc-repeat branch from f24158b to 134bb63 Feb 14, 2017

@Kwiboo

This comment has been minimized.

Copy link
Contributor Author

commented Feb 14, 2017

Updated to revert back to 1000ms delay as default delay, but keep 500ms delay for lircd-uinput.

Testing with Harmony Elite and a NUC5PPYH has shown that anything less then 700ms delay can produce double presses using input from the rc subsystem. When lirc and mceusb.lircd.conf is used (forced by custom udev rules) there was no double presses generated.

@Kwiboo

This comment has been minimized.

Copy link
Contributor Author

commented Feb 15, 2017

After some more testing I am unsure if the repeat delay needs to be reverted to 1000ms. The default setting for Harmony's command repeats was set to 3, meaning it will send IR-commands 3-4 times for each button pressed, lowering this setting to 0, 1 or 2 repeats also makes the double presses go away.

@Anuskuss

This comment has been minimized.

Copy link

commented Feb 15, 2017

@Kwiboo Sorry if unrelated but I sometimes experience some double presses while using the Official Kodi Remote (RPi2 w/ LibreELEC 7.95.3). Will this fix it?

@Kwiboo Kwiboo force-pushed the Kwiboo:master-lirc-repeat branch from 134bb63 to 3f2a9b6 Feb 17, 2017

@Kwiboo Kwiboo changed the title [master] input: change input repeat config input: change input repeat config Feb 17, 2017

@Kwiboo

This comment has been minimized.

Copy link
Contributor Author

commented Feb 17, 2017

I have now restored the original 500ms delay (the previous revert to 1000ms only affected usb hid remotes and not rc remotes) and changed the remotedelay advanced setting in kodi to 1.
This makes kodi skip the first lirc repeat event and fixes the issue with double presses using a Harmony MCE profile with command repeats set to 3. For properly configured remotes it only adds one repeat period to the initial delay.

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Feb 18, 2017

Had confirmation that the Harmony issue is fixed: http://forum.kodi.tv/showthread.php?tid=298462&pid=2529276#pid2529276

Kwiboo added 2 commits Feb 12, 2017
v4l-utils: add 70-input-repeat.rules
This moves the repeat delay config from 98-eventlircd.rules,
changes the repeat period from 33ms to 80ms for lircd-uinput
and changes the repeat delay from 1s to 500ms for all input devices.

@Kwiboo Kwiboo force-pushed the Kwiboo:master-lirc-repeat branch from 3f2a9b6 to 7ecd677 Feb 18, 2017

@Kwiboo

This comment has been minimized.

Copy link
Contributor Author

commented Feb 18, 2017

Great! Rebased, squashed and ready to merge. Matches what is included in LE8.
I will look at making the repeat delay and period configurable in kodi/settings addon in another PR.

@Anuskuss this will not fix any double presses in the kodi remote app, as this only affects input devices such as keyboards and ir remotes.

@MilhouseVH MilhouseVH merged commit 6f6e49e into LibreELEC:master Feb 18, 2017

@Kwiboo Kwiboo deleted the Kwiboo:master-lirc-repeat branch Feb 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.