Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$DEVICE naming changes #1356

Merged
merged 2 commits into from Mar 14, 2017

Conversation

@lrusak
Copy link
Member

commented Feb 16, 2017

First we want to be able to build the base project by itself. The $DEVICE should be an overlay of the base project, not it's own.

The naming should use $DEVICE.$ARCH not $PROJECT.$DEVICE.$ARCH. This makes it so we don't have to change any backend or updated things.

ping @codesnake @kszaq @kivutar and whoever else may use the $DEVICE call that this may change the way their build works.

@lrusak lrusak requested a review from chewitt Feb 16, 2017
@lrusak lrusak force-pushed the lrusak:device-name branch from 3d19bee to 4d9ab04 Feb 16, 2017
@kivutar

This comment has been minimized.

Copy link
Contributor

commented Feb 16, 2017

Your change looks OK to me.
We should also think about using $DEVICE over $SYSTEM, or the opposite, since they are similar mechanism. But that's another discussion.

@vpeter4

This comment has been minimized.

Copy link
Contributor

commented Feb 17, 2017

Like I wrote: SYSTEM has nothing to do with DEVICE. The only reason I introduce SYSTEM was to distinguish which final image to build because of different bootloader has to be used. All other pieces are the same. That's why it is not needed to build multiple projects just because of one (or few) different package.
But if this has to change than just do it.

@kivutar

This comment has been minimized.

Copy link
Contributor

commented Feb 17, 2017

OK I understand the difference now. Thanks.

@chewitt

This comment has been minimized.

Copy link
Member

commented Feb 28, 2017

@lrusak can you rebase this pls.

lrusak added 2 commits Feb 16, 2017
@lrusak lrusak force-pushed the lrusak:device-name branch from 4d9ab04 to 44dc5c9 Feb 28, 2017
@lrusak

This comment has been minimized.

Copy link
Member Author

commented Feb 28, 2017

rebased.

@lrusak

This comment has been minimized.

Copy link
Member Author

commented Mar 14, 2017

bueller?

Copy link
Member

left a comment

I was busy crashing the Ferrari..

@chewitt chewitt merged commit 5f2a479 into LibreELEC:master Mar 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.