Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPi add Slice and Slice3 devices #1357

Merged
merged 9 commits into from Mar 14, 2017

Conversation

@lrusak
Copy link
Member

commented Feb 16, 2017

This is the culmination of the ongoing work from @ghollingworth and @chewitt

I've simply rebased, cleaned up, and made relevant commits.

If we want to use $DEVICE support this is how it should be done. Everything in the devices folder should be an overlay of the main project it is dependent on. It should not be it's own project.

There are some Kodi patches in here that I am not fond of but I don't think it's possible for them to go upstream. I may have to clean them up some more.

for others this is built like so:

PROJECT=RPi DEVICE=Slice3 ARCH=arm make
PROJECT=RPi DEVICE=Slice ARCH=arm make

This depends on #1356 and #1358

@lrusak lrusak requested a review from chewitt Feb 16, 2017
@lrusak lrusak force-pushed the lrusak:slice-devices branch from d77ac70 to 4311c2b Feb 16, 2017
@lrusak lrusak changed the title Slice and Slice3 device support RPi add Slice and Slice3 devices Feb 16, 2017
@lrusak lrusak force-pushed the lrusak:slice-devices branch from 39fd13a to aedc419 Feb 16, 2017
@lrusak

This comment has been minimized.

Copy link
Member Author

commented Feb 16, 2017

This now depends on #1358 and will have to be rebased after it has merged.

@lrusak lrusak force-pushed the lrusak:slice-devices branch from aedc419 to 8cf2323 Feb 16, 2017
<l>NextSubtitle</l>
<left>StepBack</left>
<right>StepForward</right>
- <up>ChapterOrBigStepForward</up>

This comment has been minimized.

Copy link
@ghollingworth

ghollingworth Feb 18, 2017

I'm not absolutely sure about this, in general we always removed the volume capability because we expect the default to be 100% and allow the external amplifier / TV to control volume. Otherwise all that is happening is the signal to noise ratio is being reduced...

I understand that having volume up/down is nice for analogue output, but it is being connected to an amp...

This comment has been minimized.

Copy link
@lrusak

lrusak Feb 18, 2017

Author Member

This might be something that @chewitt added then

This comment has been minimized.

Copy link
@chewitt

chewitt Feb 18, 2017

Member

This is something that I deliberately changed because without it you cannot control the volume from the Slice remote. I'm used to the AppleTV remote which uses up/down for volume and I think this is a better user experience. If you do the big-step stuff with up down I am forced to use two remotes ALL THE TIME. With this change I only need one remote; if the AVR is set to a decent average volume I only occasionally need to tweak it when playing something that uses passthrough and comes out too loud/quiet.

struct cs4265_private *cs4265 = snd_soc_codec_get_drvdata(codec);
int index;
-
+printk(KERN_ERR "cs4265_pcm_hw_params: format = 0x%x, width = %d\n", cs4265->format, params_width(params));

This comment has been minimized.

Copy link
@ghollingworth

ghollingworth Feb 18, 2017

Oops... This should be left out

static int cs4265_set_bias_level(struct snd_soc_codec *codec,
enum snd_soc_bias_level level)
{
+printk(KERN_ERR "set_bias_level %d\n", level);

This comment has been minimized.

Copy link
@ghollingworth

ghollingworth Feb 18, 2017

And this... my bad I left in some debug!

@@ -1,23 +0,0 @@
[Unit]

This comment has been minimized.

Copy link
@ghollingworth

ghollingworth Feb 18, 2017

This is probably a mistake

This comment has been minimized.

Copy link
@lrusak

lrusak Feb 18, 2017

Author Member

Don't worry, it will use projects/RPi/filesystem/usr/lib/systemd/system/serial-console.service

@@ -1,28 +0,0 @@
#!/bin/sh

This comment has been minimized.

Copy link
@ghollingworth

ghollingworth Feb 18, 2017

This probably shouldn't have been removed...

This comment has been minimized.

Copy link
@lrusak

lrusak Feb 18, 2017

Author Member

same as above, it wil use projects/RPi/initramfs/platform_init

@lrusak lrusak force-pushed the lrusak:slice-devices branch from 8cf2323 to 612fcdb Feb 18, 2017
elif [ -f $PROJECT_DIR/$PROJECT/config/config.txt ]; then
cp -PRv $PROJECT_DIR/$PROJECT/config/config.txt $INSTALL/usr/share/bootloader
elif [ -f $PROJECT_DIR/$PROJECT/devices/$DEVICE/config/config.txt ]; then
cp -PRv $PROJECT_DIR/$PROJECT/devices/$DEVICE/config/config.txt $INSTALL/usr/share/bootloader
else

This comment has been minimized.

Copy link
@Kwiboo

Kwiboo Feb 18, 2017

Member

Isn't the above L60-65 in wrong order? distro/project/device instead of device/project/distro (same with L50-55)

This comment has been minimized.

Copy link
@lrusak

lrusak Feb 18, 2017

Author Member

Yes thanks

@lrusak lrusak force-pushed the lrusak:slice-devices branch from 612fcdb to 5c1855a Feb 18, 2017
echo -e "OPENELEC_ARCH=\"$PROJECT.$TARGET_ARCH\"" >> $INSTALL/etc/os-release
echo -e "LIBREELEC_ARCH=\"$PROJECT.$TARGET_ARCH\"" >> $INSTALL/etc/os-release
else
echo -e "OPENELEC_ARCH=\"$DEVICE.$TARGET_ARCH\"" >> $INSTALL/etc/os-release

This comment has been minimized.

Copy link
@MilhouseVH

MilhouseVH Mar 1, 2017

Contributor

This assumes DEVICE is somewhat unique, and you can't have the same device name for two different projects (particularly if they're the same TARGET_ARCH).

Wouldn't $PROJECT.$DEVICE.$TARGET_ARCH be a more accurate reflection of the build? I realise this may require back end changes, while the change above will work with existing infrastructure at the expense of losing some information (ie. PROJECT).

See my comments in #1358.

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Mar 1, 2017

Should the final commit, RPi: add common slice linux patches, really be adding slice patches to the whole RPi project? I know it would mean duplication but shouldn't those kernel patches be at the device level (Slice and Slice3)?

Copy link
Contributor

left a comment

Update this 01d6765 commit please as it's not common to all devices - it's Slice specific.

@lrusak lrusak force-pushed the lrusak:slice-devices branch from 5c1855a to c2fbaf2 Mar 14, 2017
@lrusak

This comment has been minimized.

Copy link
Member Author

commented Mar 14, 2017

@MilhouseVH the reason the patches were added to the project patches folder is so that it is easier to update the kernel configs otherwise we have to maintain 4 kernel configs instead of 2.

The patches won't hurt the RPi and RPi2 at all.

chewitt and others added 7 commits Mar 14, 2017
lrusak and others added 2 commits Mar 14, 2017
@lrusak lrusak force-pushed the lrusak:slice-devices branch from c2fbaf2 to 750bdc7 Mar 14, 2017
@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2017

OK, let's see how that goes... :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.