Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

projects/WeTek_Core: Switch to "hotplug" CPU scaling governor #1504

Merged
merged 1 commit into from Apr 9, 2017

Conversation

@warwickmm
Copy link
Contributor

commented Apr 5, 2017

Many WeTek Core users have been experiencing major UI lag issues when using the default "ondemand" governor. If left inactive for a period of time, the UI becomes extremely sluggish and a reboot is required.

See WeTek forum discussions:

http://www.wetekforums.com/v/index.php?p=/discussion/29713/libreelec-krypton-v7-95-2-beta/p1
http://www.wetekforums.com/v/index.php?p=/discussion/29773/libreelec-krypton-v7-95-3-beta
http://www.wetekforums.com/v/index.php?p=/discussion/29832/libreelec-krypton-v8-0-0-release/p1

and LibreElec bug reports:

https://forum.libreelec.tv/thread-4825.html
https://forum.libreelec.tv/thread-5746.html

Users did not experience this issue with LE 7. The switch from the "performance" to "interactive" governor was made in revision 8610fb3 ("projects/WeTek_Core: Use interactive CPU scaling governor by default"). Users then started experiencing the UI issues, and revision c908c1f ("projects/WeTek_Core: Switch to ondemand CPU scaling governor") attempted to address the problem. Unfortunately, this did not appear to resolve the issue.

After switching to "hotplug", users could not replicate the UI lag issues anymore. Unfortunately, this doesn't address why the slowdown issues occur with the Core, but it does provide an apparent fix.

Many WeTek Core users have been experiencing major UI lag issues when
using the "ondemand" governor.  If left inactive for a period of time,
the UI becomes extremely sluggish and a reboot is required.

Users did not experience this issue with LE 7.  The switch from the
"performance" to "interactive" governor was made in revision 8610fb3
("projects/WeTek_Core: Use interactive CPU scaling governor by
default").  Users then started experiencing the UI issues, and revision
c908c1f ("projects/WeTek_Core: Switch to ondemand CPU scaling
governor") attempted to address the problem.  Unfortunately, this did
not appear to resolve the issue.

After switching to "hotplug", users could not replicate the UI lag
issues anymore.
@CvH CvH added BUGFIX LE 9.0 labels Apr 5, 2017
@stefansaraev

This comment has been minimized.

Copy link
Contributor

commented Apr 7, 2017

@codesnake

This comment has been minimized.

Copy link
Member

commented Apr 8, 2017

I think it is OK to set hotplug governor as default for Core, until we'll find out why other governors cause such weird issue.

Thanks @warwickmm.

@chewitt
chewitt approved these changes Apr 9, 2017
Copy link
Member

left a comment

No objections. @warwickmm can you submit a backport of the same change to 8.0 branch please.

@chewitt chewitt merged commit ffa06a6 into LibreELEC:master Apr 9, 2017
chewitt added a commit that referenced this pull request Apr 9, 2017
Backport of #1504 (projects/WeTek_Core: Switch to "hotplug" CPU scaling governor)
codesnake added a commit to codesnake/LibreELEC.tv that referenced this pull request Apr 15, 2017
MilhouseVH added a commit that referenced this pull request Apr 15, 2017
projects/WeTek_Core: Fix kernel build after #1504
chewitt added a commit that referenced this pull request Apr 15, 2017
Backport of #1533 (projects/WeTek_Core: Fix kernel build after #1504)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.