Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dt-blob.bin compilation and installation to the system. #155

Merged
merged 1 commit into from Apr 14, 2016

Conversation

Projects
None yet
4 participants
@ghollingworth
Copy link

commented Apr 14, 2016

dt-blob.bin is used by the Raspberry Pi compute module to move a
number of pins around and possibly change the clock configuration
at boot time.

This isn't used by the Raspberry Pi because a default is build in, but for compute module designs where the default pins are moved this file is used to tell the firmware where those pins are.

@lrusak

This comment has been minimized.

Copy link
Member

commented Apr 14, 2016

a couple things, dtc comes from where? it must be installed on the host system?

if the cp fails the build will fail, better add a check if it exists

EDIT:
build.LibreELEC-RPi2.arm-7.0-devel/linux-4.4.6/scripts/dtc/dtc
better install this into the toolchain and access it from there

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Apr 14, 2016

better install this into the toolchain and access it from there

Or simply do what we do with mkknlimg, so...

-    dtc -O dtb -o dt-blob.bin $DISTRO_DIR/DISTRO/config/dt-blob.dts
+    $(kernel_path)/scripts/dtc/dtc -O dtb -o dt-blob.bin $DISTRO_DIR/DISTRO/config/dt-blob.dts

Edit: Simplified to use kernel_path in place of kernel_version.

@lrusak

This comment has been minimized.

Copy link
Member

commented Apr 14, 2016

that works for me

@@ -42,6 +45,7 @@ makeinstall_target() {
cp -PRv bootcode.bin $INSTALL/usr/share/bootloader
cp -PRv fixup_x.dat $INSTALL/usr/share/bootloader/fixup.dat
cp -PRv start_x.elf $INSTALL/usr/share/bootloader/start.elf
cp -PRv dt-blob.bin $INSTALL/usr/share/bootloader/dt-blob.bin

This comment has been minimized.

Copy link
@MilhouseVH

MilhouseVH Apr 14, 2016

Contributor

[ -f dt-blob.bin ] && cp ...

@@ -25,6 +25,7 @@ mkdir -p $RELEASE_DIR/3rdparty/bootloader
cp -PR $BUILD/bcm2835-bootloader-*/bootcode.bin $RELEASE_DIR/3rdparty/bootloader/
cp -PR $BUILD/bcm2835-bootloader-*/fixup_x.dat $RELEASE_DIR/3rdparty/bootloader/fixup.dat
cp -PR $BUILD/bcm2835-bootloader-*/start_x.elf $RELEASE_DIR/3rdparty/bootloader/start.elf
cp -PR $BUILD/bcm2835-bootloader-*/dt-blob.bin $RELEASE_DIR/3rdparty/bootloader/

This comment has been minimized.

Copy link
@MilhouseVH

MilhouseVH Apr 14, 2016

Contributor

[ -f $BUILD/bcm2835-bootloader-*/dt-blob.bin ] && cp ...

@@ -29,6 +29,7 @@
cp -p $SYSTEM_ROOT/usr/share/bootloader/bootcode.bin $BOOT_ROOT
cp -p $SYSTEM_ROOT/usr/share/bootloader/fixup.dat $BOOT_ROOT
cp -p $SYSTEM_ROOT/usr/share/bootloader/start.elf $BOOT_ROOT
cp -p $SYSTEM_ROOT/usr/share/bootloader/dt-blob.bin $BOOT_ROOT

This comment has been minimized.

Copy link
@MilhouseVH

MilhouseVH Apr 14, 2016

Contributor

[ -f $SYSTEM_ROOT/usr/share/bootloader/dt-blob.bin ] && cp ...

@ghollingworth

This comment has been minimized.

Copy link
Author

commented Apr 14, 2016

Awesome feedback thanks, will add squash and push again tonight

@CvH CvH added the BUILDSYSTEM label Apr 14, 2016

Gordon Hollingworth
Add dt-blob.bin compilation and installation to the system.
dt-blob.bin is used by the Raspberry Pi compute module to move a
number of pins around and possibly change the clock configuration
at boot time.

@ghollingworth ghollingworth force-pushed the ghollingworth:master branch from a77914c to f6b31dc Apr 14, 2016

@ghollingworth

This comment has been minimized.

Copy link
Author

commented Apr 14, 2016

Updated from feedback

@MilhouseVH MilhouseVH merged commit aa33d8f into LibreELEC:master Apr 14, 2016

@MikeBuzz MikeBuzz referenced this pull request Apr 15, 2016

Merged

copy the dt-blob to image #162

zalaare pushed a commit to zalaare/LibreELEC.tv that referenced this pull request Apr 15, 2016

copy the dt-blob to image
this is a follow on from LibreELEC#155

LongChair added a commit to plexinc/LibreELEC.tv that referenced this pull request Apr 16, 2016

Merge pull request LibreELEC#155 from ghollingworth/master
Add dt-blob.bin compilation and installation to the system.

LongChair added a commit to plexinc/LibreELEC.tv that referenced this pull request Apr 16, 2016

LongChair added a commit to plexinc/LibreELEC.tv that referenced this pull request Apr 16, 2016

Merge pull request LibreELEC#155 from ghollingworth/master
Add dt-blob.bin compilation and installation to the system.

LongChair added a commit to plexinc/LibreELEC.tv that referenced this pull request Apr 16, 2016

chewitt added a commit to chewitt/LibreELEC.tv that referenced this pull request Apr 16, 2016

lrusak added a commit to lrusak/LibreELEC.tv that referenced this pull request Apr 19, 2016

droidbox pushed a commit to droidbox/LibreELEC.tv that referenced this pull request Jan 3, 2017

Merge pull request LibreELEC#155 from ghollingworth/master
Add dt-blob.bin compilation and installation to the system.

droidbox pushed a commit to droidbox/LibreELEC.tv that referenced this pull request Jan 3, 2017

copy the dt-blob to image
this is a follow on from LibreELEC#155

thoradia pushed a commit to thoradia/LibreELEC.tv that referenced this pull request Feb 18, 2019

Merge pull request LibreELEC#155 from vpeter4/build_script
scripts/build: don't fail on sed with non existent file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.