Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting VendorID for TP-Link T4U v2 #1682

Merged
merged 1 commit into from Jun 14, 2017

Conversation

@marcvangend
Copy link
Contributor

commented Jun 10, 2017

As discussed in https://forum.libreelec.tv/thread/7057-tplink-archer-t4u-v2-ac1300-issue/?postID=46614, this change was once tested with the correct VendorID, but two codes were mixed up while creating the pull request. The correct USB ID for the TP-Link T4U is 2357:010d.

@marcvangend

This comment has been minimized.

Copy link
Contributor Author

commented Jun 10, 2017

@CvH Sorry, I'm not very familiar with the LE development workflow. Does your tag "LE9" mean that this change will not be considered for LE8? Or do I need to create a separate PR for that?
Thanks.

@CvH

This comment has been minimized.

Copy link
Member

commented Jun 10, 2017

@marcvangend no its just to symbolize that it goes into the master branch (LE9) - backport is of course possible :)

@marcvangend

This comment has been minimized.

Copy link
Contributor Author

commented Jun 10, 2017

OK, thanks. Anything else I can do to help getting this committed and backported?

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2017

I'll include this PR in tonight's test builds if that helps.

@marcvangend

This comment has been minimized.

Copy link
Contributor Author

commented Jun 11, 2017

Indeed the adapter is recognized correctly now.

I did have to reboot twice before it worked. After the first reboot, I was able to enable wireless networking, but connecting to the network resulted in an error (something like "network I/O error", it went away very quickly). After the second reboot, the wifi connection was established. Anyway, that's beyond the scope of this PR.

@lrusak
lrusak approved these changes Jun 14, 2017
@lrusak lrusak merged commit d5801af into LibreELEC:master Jun 14, 2017
@lrusak

This comment has been minimized.

Copy link
Member

commented Jun 14, 2017

Thanks for the PR @marcvangend

@marcvangend marcvangend deleted the marcvangend:patch-1 branch Jun 14, 2017
@marcvangend

This comment has been minimized.

Copy link
Contributor Author

commented Jan 3, 2018

@lrusak The "backport reqd" label didn't do much so far... can I help?

@chewitt

This comment has been minimized.

Copy link
Member

commented Jan 3, 2018

@marcvangend backports are normally done by the original PR submitter but that's not particularly clear from the simple addition of the label and it's been overlooked. There are no further plans for 8.2 releases now so this one isn't worth pursuing now. Thanks for the follow up.

@marcvangend

This comment has been minimized.

Copy link
Contributor Author

commented Jan 3, 2018

Thanks for the fast reply @chewitt. I just noticed that the file that was changed by this PR no longer exists. I see no references to the USB ID (2357:010d) elsewhere in the code base either. Do you know if support has been dropped, or that support has been implemented in another way?

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Jan 3, 2018

@marcvangend The new card ids were subsequently submitted upstream (which is where they should be submitted every time, ideally, and not to us) and when they were accepted we bumped to the new version of the driver (see #1816) which meant we no longer needed to patch the ids.

@chewitt you cherry-picked this commit in your LE8.2 backport PR: #1703 so all is good with LibreELEC 8.2.

@marcvangend

This comment has been minimized.

Copy link
Contributor Author

commented Jan 3, 2018

@MilhouseVH Thanks a lot for the explanation.

Now I have to go and look for other reasons why my dongle isn't working on 8.2.2 😬

@CGarces

This comment has been minimized.

Copy link
Contributor

commented Jan 3, 2018

@marcvangend
Can you confirm that not works on 8.2.2, but works fine on master?

@marcvangend

This comment has been minimized.

Copy link
Contributor Author

commented Jan 3, 2018

@CGarces No, the problem turned out to be something else. I can confirm the TP-Link T4U with USB ID 2357:010d works fine on 8.2.2.

(In case you might be interested, the wifi dongle was not connecting because there was a settings file in /storage/.cache/connman/wifi_xxx_yyy_managed_psk/settings which contained the line IPv4.local_address=192.168.77.130, even though it also contained the line IPv4.method=dhcp. This was a problem because the wired network adapter was already assigned the same IP address. After I edited the file manually, changing the IP address, it worked.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.