New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init: make break after behaviour really break after #1773

Merged
merged 1 commit into from Sep 13, 2017

Conversation

Projects
None yet
3 participants
@MilhouseVH
Contributor

MilhouseVH commented Jul 10, 2017

Just a small change to the init "break after" procedure.

Whenever debugging break=$step is configured, the init process will drop into a debug shell after $step, eg. after load_splash.

However, once you exit from $step, the boot procedure will continue to completion even if you wanted to debug a subsequent step.

This change now means that once you have reached $step and dropped into the debug shell, all subsequent steps will also break and drop into the debug shell. This gives more control over the init boot process once $step is reached.

Note that if the debug shell is entered because of an error, the existing boot-to-completion behaviour is unchanged.

In addition, the current boot step has been added to the debug shell message so that users will know where they are in the boot process... handy if using break=all.

@MilhouseVH MilhouseVH requested a review from lrusak Jul 10, 2017

@lrusak

This comment has been minimized.

Show comment
Hide comment
@lrusak

lrusak Jul 10, 2017

Member

I don't feel like this is needed over using break=all however there is no harm in adding it

Member

lrusak commented Jul 10, 2017

I don't feel like this is needed over using break=all however there is no harm in adding it

@chewitt chewitt removed the request for review from lrusak Sep 13, 2017

@chewitt chewitt merged commit 63c0f2c into LibreELEC:master Sep 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment