New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add xmlstarlet to toolchain depends #1883

Merged
merged 3 commits into from Aug 18, 2017

Conversation

Projects
None yet
3 participants
@CvH
Member

CvH commented Aug 15, 2017

PROJECT=abc ARCH=abc scripts/create_addon abc fails at clean builds due missing xmlstarlet:host

@CvH CvH requested review from MilhouseVH and lrusak Aug 15, 2017

@MilhouseVH

This comment has been minimized.

Show comment
Hide comment
@MilhouseVH

MilhouseVH Aug 16, 2017

Contributor

Unfortunately this creates a circular dependency.

toolchain will build xmlstarlet, which tries to build toolchain:

https://github.com/LibreELEC/LibreELEC.tv/blob/master/packages/textproc/xmlstarlet/package.mk#L26

Try a clean build, it will fail after forking thousands of scripts/build xmlstarlet processes.

So OK, remove toolchain from xmlstarlet as a PKG_DEPENDS_HOST dependency.

But xmlstarlet needs libxml2:host (which itself needs zlib:host) and libxslt:host, which each have a dependency on toolchain which they themselves try to build... so again toolchain tries to build xmlstarlet:host, and so it goes on, forever until the machine runs out of resources.

You need to remove toolchain from the PKG_DEPENDS_HOST of xmlstarlet and all xmlstarlet dependencies (and their dependencies) in order to "break" the circular dependency, otherwise it won't be possible to build xmlstarlet as part of toolchain.

http://sprunge.us/YUjM

I think the above patch works.

Contributor

MilhouseVH commented Aug 16, 2017

Unfortunately this creates a circular dependency.

toolchain will build xmlstarlet, which tries to build toolchain:

https://github.com/LibreELEC/LibreELEC.tv/blob/master/packages/textproc/xmlstarlet/package.mk#L26

Try a clean build, it will fail after forking thousands of scripts/build xmlstarlet processes.

So OK, remove toolchain from xmlstarlet as a PKG_DEPENDS_HOST dependency.

But xmlstarlet needs libxml2:host (which itself needs zlib:host) and libxslt:host, which each have a dependency on toolchain which they themselves try to build... so again toolchain tries to build xmlstarlet:host, and so it goes on, forever until the machine runs out of resources.

You need to remove toolchain from the PKG_DEPENDS_HOST of xmlstarlet and all xmlstarlet dependencies (and their dependencies) in order to "break" the circular dependency, otherwise it won't be possible to build xmlstarlet as part of toolchain.

http://sprunge.us/YUjM

I think the above patch works.

@CvH

This comment has been minimized.

Show comment
Hide comment
@CvH

CvH Aug 17, 2017

Member

@MilhouseVH fixed and updated pr

Member

CvH commented Aug 17, 2017

@MilhouseVH fixed and updated pr

@MilhouseVH MilhouseVH merged commit 32406a7 into LibreELEC:master Aug 18, 2017

@MilhouseVH

This comment has been minimized.

Show comment
Hide comment
@MilhouseVH

MilhouseVH Aug 18, 2017

Contributor

Please rebase #1821

Contributor

MilhouseVH commented Aug 18, 2017

Please rebase #1821

@CvH CvH deleted the CvH:9.0-xmlstarlet branch Aug 18, 2017

vpeter4 added a commit to vpeter4/LibreELEC.tv that referenced this pull request Aug 19, 2017

Merge pull request #1883 from CvH/9.0-xmlstarlet
add xmlstarlet to toolchain depends
@LongChair

This comment has been minimized.

Show comment
Hide comment
@LongChair

LongChair Nov 7, 2017

Contributor

Any chance we could backport that one to 8.2. xmlstarlet wouldn't build and keep stuck on an Ubuntu 17.10 without that patch ...

Contributor

LongChair commented Nov 7, 2017

Any chance we could backport that one to 8.2. xmlstarlet wouldn't build and keep stuck on an Ubuntu 17.10 without that patch ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment