Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux: update to linux-4.13.6 #1978

Merged
merged 16 commits into from Oct 14, 2017

Conversation

@MilhouseVH MilhouseVH force-pushed the MilhouseVH:linux4131+ branch 5 times, most recently from 1bab741 to f3f36c9 Sep 14, 2017
@MilhouseVH MilhouseVH force-pushed the MilhouseVH:linux4131+ branch 2 times, most recently from d6f95ef to 1a22637 Sep 22, 2017
@MilhouseVH MilhouseVH force-pushed the MilhouseVH:linux4131+ branch from e30113c to 38a13fc Sep 29, 2017
@MilhouseVH MilhouseVH changed the title linux: update to linux-4.13.4 linux: update to linux-4.13.6 Oct 5, 2017
@MilhouseVH

This comment has been minimized.

Copy link
Contributor Author

commented Oct 5, 2017

Due to the ongoing problems with the Kodi forum I'd rather wait until we're sure we've had no reported issues before merging this - pushing the target out to 4.13.6, hopefully the Kodi server will have been found by then.

@polojoe

This comment has been minimized.

Copy link

commented Oct 6, 2017

Could you please publish a changelog of your testbuilds in the meantime?
Maybe on milhouse.libreelec.tv ?

@MilhouseVH

This comment has been minimized.

Copy link
Contributor Author

commented Oct 6, 2017

OK, I've added temporary release threads on the LibreELEC forum:

RPi/RPi2 thread
Generic: thread

@MilhouseVH MilhouseVH force-pushed the MilhouseVH:linux4131+ branch from 837afbf to 85063d4 Oct 6, 2017
@MilhouseVH MilhouseVH force-pushed the MilhouseVH:linux4131+ branch from 85063d4 to eb95c2b Oct 13, 2017
@MilhouseVH

This comment has been minimized.

Copy link
Contributor Author

commented Oct 14, 2017

This is good to go.

@lrusak
lrusak approved these changes Oct 14, 2017
@lrusak lrusak merged commit 309894f into LibreELEC:master Oct 14, 2017
@lrusak

This comment has been minimized.

Copy link
Member

commented Oct 14, 2017

Thanks @MilhouseVH!

@the-dreamer

This comment has been minimized.

Copy link

commented Oct 18, 2017

i have updated my build (from master) and new kernel 4.13 is included. My last build was from mid/end August was with 4.12 kernel.
Now i have following crash in kernel regarding color range:
[ 15.028452] [drm:pipe_config_err] ERROR mismatch in limited_color_range (expected 1, found 0)
[ 15.028462] pipe state doesn't match!

full dmesg from boot: http://sprunge.us/NKWi

Color behaviour in kodi is also wrong. dark screen when limited color enabled and brighter screen when disabled.

Edit:
reverting this PR results in clean boot and no crash: http://sprunge.us/WIeF

@MilhouseVH

This comment has been minimized.

Copy link
Contributor Author

commented Oct 18, 2017

[    0.000000] Kernel command line: root=/dev/ram0 rdinit=/init usbcore.autosuspend=-1 BOOT_IMAGE=/KERNEL boot=LABEL=System disk=LABEL=Storage quiet initrd=/edid.cpio drm.edid_firmware=HDMI-A-3:edid/edid.bin video=HDMI-A-3:1280x720@50D

Can you try without your custom edid settings and see if the problem goes away?

Do you have the same issue with the latest build from this thread?

@the-dreamer

This comment has been minimized.

Copy link

commented Oct 24, 2017

reverting the rework of fritch patch removes the crash. So Kernel update is not the reason.
With your build i have the same crash: http://sprunge.us/AECh
Please ignore the boot cmd line for EDID due missing patch in your image: https://patchwork.freedesktop.org/patch/176284/ which should land to linux with 4.15. My Custom edid line has no affect in your build.

@MilhouseVH

This comment has been minimized.

Copy link
Contributor Author

commented Oct 24, 2017

I'm really not sure why this is causing a problem for you but none of the other 100 or so people testing these builds, that's very odd.

@the-dreamer

This comment has been minimized.

Copy link

commented Oct 24, 2017

First i thougth the crash is the reason for the dark kodi UI but have read in forum that this is an issue in latest kodi (limited color in video is fixed since 09.10). So maybe it is working for all people but they have also the crash in dmesg. What is the intention of the patch rework? in kernel 4.13.0 it is working without rework. for the latest kernel i need to see it at home.

@MilhouseVH

This comment has been minimized.

Copy link
Contributor Author

commented Oct 24, 2017

What is the intention of the patch rework? in kernel 4.13.0 it is working without rework. for the latest kernel i need to see it at home.

I'll be honest - I can't remember exactly why the passthrough patch needed to be updated. The updated version is added with 4.13.2, and my hazy recollection is that the previous version no longer builds with 4.13.2+ (but it had been fine with 4.13.0 and 4.13.1).

The version of the patch we have now came about after some collaboration with @fritsch on Team Kodi Slack, and he has now posted the patch to the intel-gfx mailing list: https://lists.freedesktop.org/archives/intel-gfx/2017-September/138971.html

Pinging @fritsch for an opinion if this patch is now causing a problem.

@the-dreamer

This comment has been minimized.

Copy link

commented Oct 24, 2017

with reverted patch rework it seems to run on 4.13.9. I could also build the kernel without patch rework: http://sprunge.us/KMEN

commit c41021650de7d33f3938f808f3ed7e7a62171c93 (HEAD -> master)
Author: root root@localhost
Date: Tue Oct 24 13:53:54 2017 +0200

Revert "linux: update full range patch from fritsch"

This reverts commit 3d76b5dca1e52b0836ff60a4a732e76f8297e233.

but as you said, fritsch can tell more i think.

@fritsch

This comment has been minimized.

Copy link
Contributor

commented Oct 24, 2017

Might be possible. Revert the updated patch for now and fall back to the older version. Will perhaps find time around christmas looking into it.

MilhouseVH added a commit to MilhouseVH/LibreELEC.tv that referenced this pull request Oct 24, 2017
@MilhouseVH

This comment has been minimized.

Copy link
Contributor Author

commented Oct 24, 2017

Many thanks, I've reverted the updated patch in #2118.

@the-dreamer please confirm if tonight's release #1024 is better for you (once it becomes available) - thanks.

MilhouseVH added a commit to MilhouseVH/LibreELEC.tv that referenced this pull request Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.