Fix Cinergy S2 USB Rev.4 #2353
Fix Cinergy S2 USB Rev.4 #2353
Conversation
|
@dcervi thanks for the submission, but no more 8.2 releases are planned. Is the change still valid against the master branch? - please test with a current milhouse 9.0/Leia build. |
|
@chewitt The master branch now changed the way DVB modules are loaded (now installed as addons), but I still think this should be merged to the 8.2 branch. Most users will stay in 8.2 until Leia reaches beta or stable status. This should also benefit other community builds like current Amlogic ones using the libreelec-8.2 branch. |
|
@CvH please merge, request rework or close as you see fit, there are no plans for more 8.2 releases and it's not my area of expertise so I have no opinion on it in the release branch. |
|
I am closing this as we don't plan to release another 8.2.x update (and its already fixed at LE9). |
|
@CvH It's sad this simple bugfix PR was closed without being merged. Now there's a new 8.2 release and this DVB tuner isn't supported. I know it's fixed at LE9 (I hadn't found time to test it yet), but LE9 is still in early Alpha stages, and I think this should be merged so if any other release comes this tuner would be supported also on LE8.2 for everyone. Can you consider re-opening the PR and merging the commit, if it's not too much work, please? |
|
@dcervi we didn't considered to release an 8.2.3 at the point of closing that pr - the main problem is that we have no real idea if it breaks something else. |
|
@CvH This was talked with Crazycat69. He mistakenly thought Cinergy S2 Rev. 4 was some DVBSky S960 clone and removed device descriptors from dw2102 driver. When his changes where merged on LE this previously supported tuner stopped working. This patch only reverses the removal, and should only have effect on the specific VID-PID of this tuner. Even Crazycat69 made this commit on his latest branch to reverse the removal of this descriptors, but unfortunately this wasn't updated on LE8.2 For me it's a little inconvenience as I have to recompile every LE8.2 release and maybe this will be the latest, but if any new user coming to LE has this tuner he would find it isn't supported on the stable release. Personally I found my otherwise almost perfect tuner stopped working after some LE8 automatic update and I have spent many hours trying to find the cause and learning how to modify a patch and submit a PR on Github. I know it's only a little grain of sand in the enormous project LE is, but I hoped my work would help other users having the same problem. Anyway I understand your concerns. I'm almost sure this won't affect any other device, but if you think otherwise, please feel free to follow your criteria. |
|
There's no promise of an 8.2.4 release, but.. |
|
ping @dcervi, $ALL Background: Rebooted my NUC and got a kernel crash with last release LibreELEC, sort of [1] ! So I plugged it in my Desktop PC running vanilla 4.15-rc9 and I got a kernel crash also ! I decided to it send the Cinergy back to the reseller. Then I saw this conversation. Under Windows 7 the Cinergy was running fine, so I exclude hardware related bugs. It was a "ID 0ccd:0105 TerraTec Electronic GmbH" as noticed here: [1] |
|
@sixpack57 This only fixes a bug that appeared on a media_build update affecting some LE 8.1.X and LE 8.2.X releases. 'media_build' is a package including drivers for many DVB devices. I know it's used by Raspberry Pi and Amlogic devices, but I don't know about x86/x64 releases as I've never used them. |
|
Thanks for info ! |
This restores support for Cinergy S2 USB Rev.4 DVB-S2 tuner. Now Cinergy S2 USB Rev.4 is working, and the new tuners added by this patch should be working as well. The modification only reverts the removal of the lines needed to support my tuner.
This is the first time I submit a pull request, so maybe I made something wrong in the process. I hope it can be reviewed and merged, so I and anyone using this tuner can return to official builds again.