Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samba: use documented browseable/writeable properties not synonyms #2409

Merged
merged 2 commits into from Jan 12, 2018

Conversation

@MilhouseVH
Copy link
Contributor

commented Jan 11, 2018

Not entirely sure if this is worthwhile, but it came up in the forum.

We use browseable and writeable (with e - British English?) in the [global] section, but the version without e (browsable/writable) in the share sections. Fortunately both are valid, with or without the e, so this is just a cosmetic issue.

I see no good reason not to be consistent, so I'm adding the missing e since the properties with e are the documented properties in smb.conf man pages (see forum link - the properties without e are just synonyms, so maybe added later due to this being a common misspelling?)

The second commit replaces the synonyms with the documented properties when used in any custom config.

Copy link
Member

left a comment

rave on brother 👍

@chewitt chewitt merged commit c76dba0 into LibreELEC:master Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.