Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
eventlircd: don't grab power buttons #2679
By routing the x86, Wetek Play and Wetek Core power buttons through eventlircd it's impossible to configure systemd-logind to use them as eventlircd is grabbing the input.
OTOH routing the power button through eventlircd is not needed as Kodi will happily use the power button's input event device.
I've successfully tested this on Generic/x86_64 but can't test on WP or WC. Would be great if someone could verify if this works - ping @codesnake
I also tested with the gpio-shutdown overlay on RPi, which creates a power button input device that's not run through eventlircd, and Kodi picked it up nicely as well so I'm rather confident the change should work on WP/WC.
Note: In my tests I also had the Kodi bump PR #2654 with the switch to libinput applied, could be that this PR depends on it
Forgot to mention, this PR introduces a subtle change: the power buttons on x86/WP/WC now hit kodi as keyboard instead of remote events which have a different default mapping in kodi.
For keyboards it's ActivateWindow(ShutdownMenu) https://github.com/xbmc/xbmc/blob/master/system/keymaps/keyboard.xml#L97, for remotes it's ShutDown() https://github.com/xbmc/xbmc/blob/master/system/keymaps/remote.xml#L53
Not sure why the keymaps differ, but personally I prefer the shutdown menu so I see this as an improvement :)
@HiassofT @mglae The trac ticket makes an observation/statement that two things are different and asks for opinions. It's not clear to me (or the developer who responded on trac) what you're asking for an opinion on? - I think things got lost in translation a little. Please add some context to the ticket and state what action you'd like to see taken.