Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eventlircd: don't grab power buttons #2679

Merged
merged 1 commit into from May 28, 2018

Conversation

@HiassofT
Copy link
Member

commented May 1, 2018

By routing the x86, Wetek Play and Wetek Core power buttons through eventlircd it's impossible to configure systemd-logind to use them as eventlircd is grabbing the input.

OTOH routing the power button through eventlircd is not needed as Kodi will happily use the power button's input event device.

I've successfully tested this on Generic/x86_64 but can't test on WP or WC. Would be great if someone could verify if this works - ping @codesnake

I also tested with the gpio-shutdown overlay on RPi, which creates a power button input device that's not run through eventlircd, and Kodi picked it up nicely as well so I'm rather confident the change should work on WP/WC.

Note: In my tests I also had the Kodi bump PR #2654 with the switch to libinput applied, could be that this PR depends on it

Signed-off-by: Matthias Reichl <hias@horus.com>
@HiassofT

This comment has been minimized.

Copy link
Member Author

commented May 1, 2018

Forgot to mention, this PR introduces a subtle change: the power buttons on x86/WP/WC now hit kodi as keyboard instead of remote events which have a different default mapping in kodi.

For keyboards it's ActivateWindow(ShutdownMenu) https://github.com/xbmc/xbmc/blob/master/system/keymaps/keyboard.xml#L97, for remotes it's ShutDown() https://github.com/xbmc/xbmc/blob/master/system/keymaps/remote.xml#L53

Not sure why the keymaps differ, but personally I prefer the shutdown menu so I see this as an improvement :)

@mglae

This comment has been minimized.

Copy link
Contributor

commented May 5, 2018

Users seems to expect direct shutdown on power key press, at least there are no common complaints about it.

I vote for keeping the behavior by i.e. adding kodi-100.26-keymap-power.patch

@HiassofT

This comment has been minimized.

Copy link
Member Author

commented May 5, 2018

@mglae I prefer to avoid downstream patches, so could you open a trac ticket on kodi? Having different defaults for keyboard and remote is a bit odd.

Depending on the result of that we can then decide if we want to patch kodi

@mglae

This comment has been minimized.

Copy link
Contributor

commented May 6, 2018

Done.

@chewitt

This comment has been minimized.

Copy link
Member

commented May 13, 2018

@HiassofT @mglae The trac ticket makes an observation/statement that two things are different and asks for opinions. It's not clear to me (or the developer who responded on trac) what you're asking for an opinion on? - I think things got lost in translation a little. Please add some context to the ticket and state what action you'd like to see taken.

@HiassofT

This comment has been minimized.

Copy link
Member Author

commented May 13, 2018

@HiassofT

This comment has been minimized.

Copy link
Member Author

commented May 28, 2018

This PR has been in Milhouse testbuilds since May 1st and so far @mglae seems to be the only one who requested a change to kodi's default keymap.

Therefore I'm inclined to keep kodi's keymap as is to avoid adding an unnecessary downstream patch.

@chewitt chewitt merged commit e0b30c3 into LibreELEC:master May 28, 2018
@HiassofT HiassofT deleted the HiassofT:le9-eventlircd-power branch Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.