Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soxr: don't create libavutil dependency on ARM #2752

Merged
merged 1 commit into from Jun 5, 2018

Conversation

@HiassofT
Copy link
Member

commented Jun 5, 2018

This prevents soxr getting a dependency on libavutil/libavcodec
and fixes pulseaudio build failures on ARM.

@CvH CvH added BUGFIX LE 9.0 labels Jun 5, 2018
@CvH
CvH approved these changes Jun 5, 2018
@HiassofT

This comment has been minimized.

Copy link
Member Author

commented Jun 5, 2018

do not merge yet, this might need a bit tweaking for RPi1

When both SIMD/NEON optimized and non-SIMD resamplers are built
soxr uses libavutil to do runtime CPU detection to switch
between these.

Avoid that by enabling only one of them depending on NEON
availability.

Also explicitly disable AVFFT to avoid picking up a dependency
on libavcodec.

Signed-off-by: Matthias Reichl <hias@horus.com>
@HiassofT HiassofT force-pushed the HiassofT:le9-soxr branch from b92afb8 to c0c0c08 Jun 5, 2018
@HiassofT HiassofT changed the title soxr: explicitly disable CR32 and AVFFT soxr: don't create libavutil dependency on ARM Jun 5, 2018
@HiassofT

This comment has been minimized.

Copy link
Member Author

commented Jun 5, 2018

I pushed an updated version. Instead of disabling CR32 we make sure that either CR32 or CR32S are enabled on ARM - so there's no need for soxr to do runtime CPU detection

pulseaudio built fine both for RPi and RPi2 with this change

@CvH CvH merged commit 598f67c into LibreELEC:master Jun 5, 2018
@HiassofT HiassofT deleted the HiassofT:le9-soxr branch Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.