Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chrome browser #2790

Merged
merged 28 commits into from Jun 26, 2018
Merged

chrome browser #2790

merged 28 commits into from Jun 26, 2018

Conversation

@CvH
Copy link
Member

CvH commented Jun 21, 2018

This adds the chrome browser based around the work from @escalade (pls have a look if you are happy with the copyright notices - not sure if I missed one).

Why this add-on instead of the chromium:

  • its just 4mb (+ 50mb download after installation) instead ~110mb
  • its easy to maintain and updates are no longer a problem (also added an way to update manually
    $ chrome-downloader latest )
  • reorganised and mass updated the dependencies
  • chrome ships all "scary" libs so we don't need to care about that and we are NOT shipping chrome, just the needed system libs and an download script that the user is able to download Chrome
  • nobody need to waste his time anymore to get a new version of chromium building (@InuSasha :) )

meh stuff:

  • chrome-libs: initial package - its an wrapper to build the shared libs that are needed, not too nice but otherwise we had to change the system libs (someone an better idea??)
  • cairo: enable gobject - I needed to activate gobject at cairo, should not conflict with something else I guess ?
  • the start script includes an workaround/hack to allow sound, with running pulseaudio chrome denies playing videos for some reason since version ~>64

testbin:

http://cvh.libreelec.tv/test/chrome/chrome.mp4

supersedes #2740

@escalade

This comment has been minimized.

Copy link
Contributor

escalade commented Jun 21, 2018

Great work, happy to have inspired the idea. Perhaps you could do the same with Spotify ;)

esac

# check for enough free disk space
if [ $(df . | tail -n1 | awk '{print $4}') -lt 400000 ]; then

This comment has been minimized.

Copy link
@vpeter4

vpeter4 Jun 21, 2018

Contributor

Skip tail and use df . | awk 'END {print $4}'.

'latest')
CHROME_VER="$(curl -s https://dl.google.com/linux/chrome/rpm/stable/x86_64/repodata/other.xml.gz | \
gzip -df | awk -F\" '/pkgid/{ sub(".*-","",$4); print $4": "$10 }' | \
grep ^stable | awk '{ print $2; }')"

This comment has been minimized.

Copy link
@vpeter4

vpeter4 Jun 21, 2018

Contributor

What about without grep and using only awk '/^stable/{ print $2; }'.
Or just with one awk: awk -F\" '/pkgid.*-stable/{ sub(".*-","",$4); print $10 }'.
Or just awk -F\" '/pkgid.*-stable/{ print $10 }'.

@CvH CvH force-pushed the CvH:9.0-chrome-final branch from d6ff3fb to afcb90b Jun 21, 2018
@CvH

This comment has been minimized.

Copy link
Member Author

CvH commented Jun 21, 2018

@vpeter4 tx changed, looks better and cleaner :)

@CvH CvH force-pushed the CvH:9.0-chrome-final branch 2 times, most recently from 63dc938 to 3a7a47c Jun 21, 2018
@CvH CvH removed the WORK IN PROGRESS label Jun 24, 2018
@CvH CvH force-pushed the CvH:9.0-chrome-final branch from 3a7a47c to 0fb68be Jun 25, 2018
Copy link
Member

chewitt left a comment

Nice work :)

@chewitt chewitt merged commit 259242a into LibreELEC:master Jun 26, 2018
@CvH CvH deleted the CvH:9.0-chrome-final branch Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.