New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scripts/create_addon: minor cleanup #2854

Merged

CvH merged 1 commit into LibreELEC:master from MilhouseVH:le90_pr2773_cleanup

Aug 2, 2018

Contributor

MilhouseVH commented Aug 1, 2018

Use POSIX compliant operators (ie. = not ==, consistent with existing code), and numeric operators when comparing numeric values
Ignore $SHELL as it can't be trusted - for example when SHELL=/bin/sh is set in /etc/crontab (as is the default on Ubuntu), and an add-on is built using a cron job, scripts/create_addon will fail:

Building addon: tvheadend42 for pi1...
Cleaning tvheadend42                         RPi/arm/devel
/bin/sh: 1: [: unexpected operator
/bin/sh: 2: ./config/options: [[: not found
/bin/sh: 372: config/functions: Syntax error: "(" unexpected (expecting "fi")
ERROR: 'tvheadend42' matches nothing...
for more informations type: ./scripts/create_addon --help


          scripts/create_addon: minor cleanup

1defb5a

MilhouseVH added BUGFIX BUILDSYSTEM LE 9.0 CLEANUP labels

Member

InuSasha commented Aug 2, 2018

lgtm

CvH approved these changes

View reviewed changes

CvH merged commit c26408a into LibreELEC:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment