Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4l-utils: remove broken and unused keymaps #3007

Merged
merged 1 commit into from Oct 1, 2018

Conversation

@HiassofT
Copy link
Member

commented Sep 30, 2018

hp_mce and zotac_ad10 won't work properly, the kernel doesn't
handle the listed scancodes as the MCE subvariant of RC6 so every
other buttonpress would be missing. Also HP MCE remotes generate
standard scancodes that are handled by the rc6_mce keymap and the
hp_mce keymap contains very odd scancodes which means it's probably
garbage (and badly named).

The samsung keymap doensn't contain any info about which actual
remote it should be used for and might clash with upstream if
a samsung keymap would be added there.

As none of these keymaps are activated by default anymore in
LibreELEC let's just remove them.

hp_mce and zotac_ad10 won't work properly, the kernel doesn't
handle the listed scancodes as the MCE subvariant of RC6 so every
other buttonpress would be missing. Also HP MCE remotes generate
standard scancodes that are handled by the rc6_mce keymap and the
hp_mce keymap contains very odd scancodes which means it's probably
garbage (and badly named).

The samsung keymap doensn't contain any info about which actual
remote it should be used for and might clash with upstream if
a samsung keymap would be added there.

As none of these keymaps are activated by default anymore in
LibreELEC let's just remove them.

Signed-off-by: Matthias Reichl <hias@horus.com>
@chewitt
chewitt approved these changes Oct 1, 2018
@chewitt chewitt merged commit bf09c1f into LibreELEC:master Oct 1, 2018
@HiassofT HiassofT deleted the HiassofT:le9-cleanup-keymaps branch Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.