config/functions: next wave of cleanups #3040
This series reorganizes and does cleanup on config/functions. Specifically it:
Adds a die() function, as previously seen in the download-cleaner PR.
Reorganizes all functions into groups based on what they do, and when they are referenced. Functions used by other functions -> buildsystem -> package -> kernel package -> addon package -> target configuration. This commit makes no function changes, only location in the file.
Converts which to command -v, and exit calls to die().
Splits check_config() into its individual checks, adds a check_distro(), and does a cleanup pass.
Built without incident for RPi2.
This reorganizes functions based on their purpose as well as strives to declare a function prior to another function calling it. No changes in how any function is implemented. Purpose groupings: Function - functions that make it easier to implement other functions Buildsystem - functions around the build environment Package - functions that work with packages or configure them Kernel - functions for getting information on the kernel/firmware Addon - functions around building kodi addons Target Configuration - Functions that set something up on the target Signed-off-by: Ian Leonard <firstname.lastname@example.org>
die is meant to be a more flexible exit, printing a message to go with the exit call. It works like: die -- same as "exit 1" die "It just broke." -- echo statement, exit value 1 die "Tried to do the thing." "2" -- echo statement, exit value 2 Exit codes other than 1 require a message to go with it. it would replace existing code that looks like: echo "ERROR: Everything went wrong. Sorry!" exit 1 or be more helpful in picking up the pieces when something unexpected happens then: do_something || exit 1 Signed-off-by: Ian Leonard <email@example.com>