Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eventlircd: prevent race with libinput / kodi #3081

Merged
merged 1 commit into from Nov 6, 2018

Conversation

@HiassofT
Copy link
Member

commented Nov 4, 2018

Currently both eventlircd and kodi try to grab input devices
which leads to a nasty race. If kodi wins the race eventlircd
can't do the keycode to lirc translation and users are left
with non-working buttons like OK.

Setting the LIBINPUT_IGNORE_DEVICE udev property for input
devices handled by eventlircd prevents the race as libinput
will then ignore these devices and kodi won't try to grab them.

Note: several users have been using systemctl mask eventlircd and setup custom IR keytables (changing eg KEY_OK to KEY_ENTER) to get longpress support in kodi.

This hack (which was never officiially supported) won't work any longer, instead of masking the eventlircd service people now have to override the eventlircd udev rule file, eg via
: > /storage/.config/udev.rules.d/98-eventlircd.rules

ping @lrusak

Currently both eventlircd and kodi try to grab input devices
which leads to a nasty race. If kodi wins the race eventlircd
can't do the keycode to lirc translation and users are left
with non-working buttons like OK.

Setting the LIBINPUT_IGNORE_DEVICE udev property for input
devices handled by eventlircd prevents the race as libinput
will then ignore these devices and kodi won't try to grab them.

Signed-off-by: Matthias Reichl <hias@horus.com>
@lrusak
lrusak approved these changes Nov 5, 2018
Copy link
Member

left a comment

Just any FYI for interested people link

@CvH CvH merged commit 8b0ed0b into LibreELEC:master Nov 6, 2018
@HiassofT HiassofT deleted the HiassofT:le9-fix-input-race branch Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.