Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eventlircd: Fix OSMC Remote ContextMenu mapping #3116

Merged
merged 1 commit into from Nov 24, 2018

Conversation

@dagwieers
Copy link
Contributor

commented Nov 21, 2018

Without this fix, the context-menu key on the OSMC remote will fail to work, and maps to the EPG (TV channel guide).

This is discussed in osmc/osmc#478

@dagwieers dagwieers force-pushed the dagwieers:patch-2 branch 2 times, most recently from 515e1f0 to 222f885 Nov 21, 2018
@dagwieers dagwieers changed the title Fix the OSMC key-event mapping for ContextMenu Fix the OSMC remote key-event mapping for ContextMenu Nov 21, 2018
@HiassofT

This comment has been minimized.

Copy link
Member

commented Nov 21, 2018

Thanks for the patch, it looks fine to me!

Just a small nit: could you change the commit message to eventlircd: fix OSMC context menu mapping?

We usually include the changed package in the commit message so it's easier to recognize which package/part of LE is affected by a commit

@dagwieers

This comment has been minimized.

Copy link
Contributor Author

commented Nov 22, 2018

Based on feedback from OSMC I am going to try some more things, and then I will update the title too.

Without this fix, the context-menu key on the OSMC remote will fail to work, and maps to the EPG (TV channel guide).
This is discussed in osmc/osmc#478
@dagwieers dagwieers force-pushed the dagwieers:patch-2 branch from 222f885 to 3a5af7a Nov 22, 2018
@dagwieers dagwieers changed the title Fix the OSMC remote key-event mapping for ContextMenu eventlircd: Fix OSMC Remote ContextMenu mapping Nov 22, 2018
@dagwieers

This comment has been minimized.

Copy link
Contributor Author

commented Nov 23, 2018

@HiassofT I can confirm that this fix (and only this fix) is needed to make it work on LibreELEC 8.90.X !

Copy link
Member

left a comment

Thanks!

@HiassofT HiassofT merged commit ae94a89 into LibreELEC:master Nov 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.