Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildsystem: add absolute patch dirs, remove unecessary sub-process, other cleanup #3661

Merged
merged 14 commits into from Jul 11, 2019

Conversation

@MilhouseVH
Copy link
Contributor

MilhouseVH commented Jul 6, 2019

Add support for absolute paths to PKG_PATCH_DIRS, simplifying #3635

Stop using a sub-process around the call to unpack() as this creates undesirable non-standard behaviour - any variables modified within the function call are "lost" as a result of being modified in the sub-process.

Fix misconfigured packages, and remove files that no longer serve any purpose since the introduction of PKG_DEPENDS_UNPACK.

@vpeter4

This comment has been minimized.

Copy link
Contributor

vpeter4 commented Jul 6, 2019

Try to build chrome-libxcb after you remove sources/libxcb. For me it doesn't work on master + this pr - sources are not downloaded. Or maybe I'm doing something wrong :)

@vpeter4

This comment has been minimized.

Copy link
Contributor

vpeter4 commented Jul 6, 2019

Run this first (chrome-libxcb is build)

./scripts/clean libxcb
./scripts/clean chrome-libxcb
rm -fr sources/libxcb
./scripts/build chrome-libxcb

then run this and chrome-libxcb is not build because sources are not downloaded

./scripts/clean chrome-libxcb
rm -fr sources/libxcb
./scripts/build chrome-libxcb

So if the package is build sources will not be downloaded even if they don't exist. Small buildsystem bug?

@MilhouseVH

This comment has been minimized.

Copy link
Contributor Author

MilhouseVH commented Jul 6, 2019

Thanks, I'll investigate later this evening and fix.

@MilhouseVH

This comment has been minimized.

Copy link
Contributor Author

MilhouseVH commented Jul 6, 2019

I think the recursive unpack change I made earlier in the week may be responsible for this - I'm guessing that chrome-libxcb fails to unpack because libxcb is already unpacked so it (libxcb) doesn't download the missing tarball, causing chrome-libxcb to fail. Will confirm once I'm at the PC later.

@MilhouseVH

This comment has been minimized.

Copy link
Contributor Author

MilhouseVH commented Jul 6, 2019

I think if the call to scripts/get is restored to its original place in scripts/unpack (after the first pkg_lock(), before the PKG_DEPENDS_UNPACK processing) then it should work OK. Not tested...

@MilhouseVH

This comment has been minimized.

Copy link
Contributor Author

MilhouseVH commented Jul 6, 2019

@vpeter4 OK it was as I suspected - fix pushed.

@MilhouseVH MilhouseVH force-pushed the MilhouseVH:le10_abs_patch_dir branch 4 times, most recently from d8e3796 to f8f5b8b Jul 6, 2019
@MilhouseVH MilhouseVH force-pushed the MilhouseVH:le10_abs_patch_dir branch from f8f5b8b to b63c474 Jul 8, 2019
MilhouseVH added 2 commits Jul 7, 2019
initramfs is currently built from within linux:target which is a problem
yet to be solved as it should be built as separately scheduled processes
just like everything else.

As we build initramfs from within linux:target, once initramfs is
finished it emits an "UNLOCK" event which is the last event for the
linux:target package until it too finishes, perhaps 5 or 10 minutes later.
During this 5-10 minute period the dashboard gives the impression that
initramfs is "stuck" in an UNLOCKed state when in fact processing continues
within linux:target, which is now the "ACTIVE" package for the process slot.

Until the initramfs scheduling problem is resolved, emit an extra "ACTIVE"
event upon returning to linux:target correcting the dashboard (and also
tools/mtstats.py elapsed time accumulation).
@MilhouseVH MilhouseVH force-pushed the MilhouseVH:le10_abs_patch_dir branch from b63c474 to 2bae815 Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.