Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel-firmware: add MediaTek mt7610 firmware #4184

Merged
merged 2 commits into from
Feb 19, 2020
Merged

kernel-firmware: add MediaTek mt7610 firmware #4184

merged 2 commits into from
Feb 19, 2020

Conversation

MilhouseVH
Copy link
Contributor

@MilhouseVH MilhouseVH commented Feb 6, 2020

https://forum.libreelec.tv/thread/21319-solved-osmc-wifi-dongle-on-rpi/?postID=134349#post134349

160KB addition

-rw-rw-r--  1 neil neil  80680 Feb  4 17:23 mt7610e.bin
-rw-rw-r--  1 neil neil  80288 Feb  4 17:23 mt7610u.bin

Edit: The mt7610e is for PCI adapters, currently only supported by Generic, and not worth the hassle of differentiating.

@chewitt
Copy link
Member

chewitt commented Feb 7, 2020

Only the mt7610u firmware is required. I've never seen the PCIe version used and nobody is asking for it to be included.

@MilhouseVH
Copy link
Contributor Author

MilhouseVH commented Feb 7, 2020

If we don't include the MT7610E firmware we should disable MT7610E support in the Generic kernel as it's unlikely to be working if we don't include the firmware. I can include the MT7610E firmware in the x86 build only (just couldn't be arsed) or drop it completely and disable it in the Generic kernel (really can't be arsed) - what's your preference?

@chewitt
Copy link
Member

chewitt commented Feb 7, 2020

I'd disable the module in the kernel. It doesn't work and nobody is complaining. I've only seen this chip used in USB devices. Let's avoid the death of a thousand cuts.

@MilhouseVH
Copy link
Contributor Author

Disabled in kernel (where enabled) and no longer including mt7610e.bin firmware.

@chewitt chewitt merged commit 3ba3f3e into LibreELEC:master Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants