linux: set DTC_FLAGS as environment variable instead of make argument #5133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting DTC_FLAGS as a make argument overrides the additional dtc flags which are added in kernel's scripts/Makefile.lib. This results in lots of noisy warnings when building RPi DT and overlays and could be potentially problematic if kbuild adds important dtc flags. Pass in DTC_FLAGS as an environment variable so that kbuild can adjust DTC_FLAGS as needed. Signed-off-by: Matthias Reichl <hias@horus.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting DTC_FLAGS as a make argument overrides the additional dtc flags
which are added in kernel's scripts/Makefile.lib.
This results in lots of noisy warnings when building RPi DT and overlays
and could be potentially problematic if kbuild adds important dtc flags.
Pass in DTC_FLAGS as an environment variable so that kbuild can
adjust DTC_FLAGS as needed.
@jernejsk I did an AW A64 kernel build and fdtdump showed that symbols were present in dtbs but doing a runtime test probably wouldn't hurt