Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Licence updated #547

Merged
merged 1 commit into from Jul 20, 2016

Conversation

@drieschel
Copy link
Contributor

commented Jul 18, 2016

It's the licence update in the files, which was discussed after the PR was already merged: #541 (diff)

@@ -1,20 +1,20 @@
#!/bin/sh
################################################################################
# This file is part of OpenELEC - http://www.openelec.tv
# Copyright (C) 2014 Alex Deryskyba (alex@codesnake.com)

This comment has been minimized.

Copy link
@stefansaraev

stefansaraev Jul 18, 2016

Contributor

look at git log projects/WeTek_Core/initramfs/platform_init and keep this one ;)

This comment has been minimized.

Copy link
@drieschel

drieschel Jul 18, 2016

Author Contributor

WTF?! The old PR was open for some days and anybody could have said that the copyright is not okay. After the PR was merged the copyright thing was faulted and I did what was proposed.

This comment has been minimized.

Copy link
@stefansaraev

stefansaraev Jul 18, 2016

Contributor

sorry, I missed the old PR. copyright of this code may be LibreELEC. copyright != authorship. you can't just replace the original author of this code with yourself. you are not the author of this code.

This comment has been minimized.

Copy link
@CvH

CvH Jul 18, 2016

Member

The problem is nobody knows who has written what (or maybe copied from fork xyz) - codesnake said he hasn't done it (so obviously no need to add a copyright for that) but we are also unsure how to handle it properly - due we are unsure we stay with the "old" licence instead of our own.

This comment has been minimized.

Copy link
@stefansaraev

stefansaraev Jul 18, 2016

Contributor

and I am sure Alex is the one who wrote this, back in time, everyone c/p'd license headers when contributing to OE. so Stephen Raue is listed everywhere, but Alex is the author. if you are unsure, dont touch it :)

This comment has been minimized.

Copy link
@stefansaraev

stefansaraev Jul 18, 2016

Contributor

@CvH

The problem is nobody knows who has written ...

does not matter.

I am the author of near half of LE. I never added myself as an author. nobody cares. but no need to remove people from license headers. and adding yourself as the only author in a file, where you only chanced a copyright header is obviously not the right thing to do. when in doubt - git log is your best friend. and dont touch names/emails. replacing OpenELEC with LibreELEC is perfectly fine as OE copyright does not apply to this git repository.

EDIT: removing people may be fine as long you dont add others (it's also fine if you remove the code they contributed), and keep the project on git (and not force pushing to hide history) so those interested can use 'git log'..

This comment has been minimized.

Copy link
@drieschel

drieschel Jul 18, 2016

Author Contributor

I wrote the changes which were the reason of the last PR (so I am the author of the changes) but I didn't create the file. What are we gonna do now? I don't care if my name is in the file or not. I would put the old authors in combined with OpenElec substituted with LibreELEC. What do you think guys?

@CvH I think Codesnake meant that he didn't do the changes in the last PR.

This comment has been minimized.

Copy link
@stefansaraev

stefansaraev Jul 18, 2016

Contributor

keep Alex's name and email (yep, trust me on that!), replace each instance of OpenELEC with LibreELEC. all good, everyone is happy :)

This comment has been minimized.

Copy link
@drieschel

drieschel Jul 18, 2016

Author Contributor

Done.^^

This comment has been minimized.

Copy link
@CvH

CvH Jul 18, 2016

Member

@stefansaraev I wasn't voting for dropping any copyright, I read it as codesnake said he hasn't done there something (my fault) therefor would it be unnecessary to include any copyright for him (tx to clarify that). As said we have problems to claim who has done what and therefore we keep the existing copyright (looks like that drop was overseen in review).

@@ -1,20 +1,20 @@
#!/bin/sh
################################################################################
# This file is part of OpenELEC - http://www.openelec.tv
# Copyright (C) 2014 Alex Deryskyba (alex@codesnake.com)

This comment has been minimized.

Copy link
@stefansaraev

stefansaraev Jul 18, 2016

Contributor

same here.

@drieschel drieschel force-pushed the drieschel:licence-update branch from f179cac to e24fcc8 Jul 18, 2016
@chewitt chewitt merged commit 19b259b into LibreELEC:master Jul 20, 2016
@drieschel drieschel deleted the drieschel:licence-update branch Jul 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.