Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package updates #555

Merged
merged 18 commits into from Jul 25, 2016

Conversation

Projects
None yet
3 participants
@lrusak
Copy link
Member

commented Jul 20, 2016

most of these are trivial maintenance updates.

busybox is the biggest update, but nothing new has been enabled in the configs.

Just building a clean image now with these changes

@lrusak lrusak force-pushed the lrusak:package-updates branch from 4a44078 to 0c5bc2d Jul 20, 2016

@lrusak

This comment has been minimized.

Copy link
Member Author

commented Jul 20, 2016

Everything built ok

@lrusak lrusak removed the MERGE BLOCKED label Jul 20, 2016

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Jul 20, 2016

Thanks. I'll clean build overnight and include this in the #721 build.

@escalade

This comment has been minimized.

Copy link
Contributor

commented Jul 21, 2016

Have you tried rebuilding the kernel/initrd? I've experimented with Busybox 1.25.0 in my own build previously, and the init version of busybox required libcrypt.so so had to add that to glibc makeinstall_init. I don't know if that's the case here, but I used the config from 1.24.2 and just hit enter for the new config options.

EDIT: Never mind, rebuilt with this PR and the init busybox is not linked to libcrypt.

@lrusak

This comment has been minimized.

Copy link
Member Author

commented Jul 21, 2016

@escalade I didn't have such a problem, I also selected N for all the new options.

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Jul 21, 2016

I built RPi, RPi2 and Generic (all clean) without any issues.

@lrusak

This comment has been minimized.

Copy link
Member Author

commented Jul 21, 2016

Merge?

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Jul 21, 2016

Any particular rush? It's just gone into a "nightly" (my test builds) so I'd rather see this tested for 1-2 days before merging (assuming there's no negative reports etc.)

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2016

Got a problem report: http://forum.kodi.tv/showthread.php?tid=269815&pid=2379814#pid2379814

Since build #0721 (which is when I first included this PR - a clean build) the Chromium add-on no longer works.

Running Chromium from the command line results in the following error:

NUC:~ # chromium
/storage/.kodi/addons/browser.chromium/bin/chromium.bin: symbol lookup error: /storage/.kodi/addons/browser.chromium/bin/chromium.bin: undefined symbol: png_set_longjmp_fn

In build #0720, Chromium works normally.

libpng-1.6.23 appears to include the png_set_longjmp_fn function/symbol. libpng isn't being built shared, and Chromium is using a static version of libpng so in theory bumping libpng shouldn't have affected Chromium.

However, libfreetype.so.6.12.3 (build #720) includes a reference to png_set_longjmp_fn, but there is no such reference in libfreetype.so.6.12.5 (build #721), and Chromium is dynamically linked to libfreetype.so.6, so that might be the reason.

libfreetype doesn't appear to be a package dependency for Chromium, when it probably should be.

Ideas? Rebuilding Chromium against the updated libfreetype might work... or the build might fail due to the missing symbol.

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2016

Copying libfreetype.so.6.12.3 (from build #720) to /storage/.kodi/addons/browser.chromium/lib/libfreetype.so.6 allows Chromium to start successfully in build #721, so it definitely looks like the updated libfreetype.so.6.12.5 is the issue.

This might be a Chromium issue, or a libfreetype issue. Not really sure...

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2016

Looking at the freetype build directory without this PR:

neil@nm-linux:~/projects/scratch/alternates/LibreELEC.tv/build.LibreELEC-Generic.x86_64-8.0-devel/freetype-2.6.3$ readelf -s ./.x86_64-libreelec-linux-gnu/.libs/libfreetype.so.6.12.3 | grep png_set_longjmp_fn
   341: 000000000002c344   172 FUNC    GLOBAL DEFAULT   11 png_set_longjmp_fn
  1505: 000000000002c344   172 FUNC    GLOBAL DEFAULT   11 png_set_longjmp_fn
neil@nm-linux:~/projects/scratch/alternates/LibreELEC.tv/build.LibreELEC-Generic.x86_64-8.0-devel/freetype-2.6.3$ readelf -s ./.install_pkg/usr/lib/libfreetype.so.6.12.3 | grep png_set_longjmp_fn
   341: 000000000002c344   172 FUNC    GLOBAL DEFAULT   11 png_set_longjmp_fn

and now with this PR:

neil@nm-linux:~/projects/LibreELEC.tv/build.LibreELEC-Generic.x86_64-8.0-devel/freetype-2.6.5$ readelf -s ./.x86_64-libreelec-linux-gnu/.libs/libfreetype.so.6.12.5 | grep png_set_longjmp_fn
  1008: 000000000001f898   120 FUNC    LOCAL  HIDDEN    11 png_set_longjmp_fn.constp
neil@nm-linux:~/projects/LibreELEC.tv/build.LibreELEC-Generic.x86_64-8.0-devel/freetype-2.6.5$ readelf -s ./.install_pkg/usr/lib/libfreetype.so.6.12.5 | grep png_set_longjmp_fn
@lrusak

This comment has been minimized.

Copy link
Member Author

commented Jul 25, 2016

I'll just drop the freetype update for now until I have to to build and test chromium

@lrusak lrusak force-pushed the lrusak:package-updates branch from 0c5bc2d to 8ea5dbf Jul 25, 2016

@lrusak lrusak force-pushed the lrusak:package-updates branch from 8ea5dbf to d9e3ba6 Jul 25, 2016

@lrusak

This comment has been minimized.

Copy link
Member Author

commented Jul 25, 2016

done

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2016

Thanks Chromium works again.

@MilhouseVH MilhouseVH merged commit 6a1e71a into LibreELEC:master Jul 25, 2016

@MilhouseVH MilhouseVH referenced this pull request Sep 7, 2016

Merged

Package updates #690

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.