Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RBP: Add GL symlinks to toolchain #606

Merged
merged 1 commit into from Aug 5, 2016
Merged

Conversation

@MilhouseVH
Copy link
Contributor

MilhouseVH commented Aug 4, 2016

Pushing this as an alternative to #605.

On RPi the libEGL/libGLESv2 libraries are now called libbrcmEGL/libbrcmGLESv2. This breaks addons that expect to link against libEGL/libGLESv2.

The background for the renaming is in this change: raspberrypi/firmware#625 (comment).

This PR will create sym links in the toolchain that will allow RPi builds to appear "normal" as far as libEGL/libGLESv2 are concerned, allowing untouched addons to build against these libraries (that are just symbolic links to the real things - libbrcm*).

We already include sym links in the image for libEGL/libGLESv2, to libbrcm*, these are intended for backward compatibility but while we ourselves continue to link against libEGL/libGLESv2 they will always be required.

With #605 we would at least be linking against the correct libbrcmEGL/libbrcmGLESv2 libraries - this is really the biggest difference between the two solutions, however while we continue to include the sym links for libEGL/libGLESv2 in the image, it's probably only a very minor benefit.

Push this PR or #605, they're both valid changes.

@lrusak

This comment has been minimized.

Copy link
Member

lrusak commented Aug 5, 2016

I vote this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.