Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WeTek: RELEASE_DIR removing fix #625

Merged
merged 1 commit into from Aug 15, 2016

Conversation

@drieschel
Copy link
Contributor

commented Aug 15, 2016

The $RELEASE_DIR will be removed now after building a WeTek Core/Play image. I also revised the line indention for better reading.

@kszaq

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2016

Isn't the release dir removed after 2edb119 ?

@drieschel

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2016

No, it wasn't.

@kszaq

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2016

Okay, I asked as cherry-picking that change made the RELEASE_DIR disappear in my fork.

pushd sign > /dev/null
echo --update_package=/sdcard/$IMAGE_NAME-update.zip > factory_update_param.aml
if [ -f "$INSTALL_SRC_DIR/files/recovery.img" ]; then
cp $INSTALL_SRC_DIR/files/recovery.img .

This comment has been minimized.

Copy link
@drieschel

drieschel Aug 15, 2016

Author Contributor

I also changed the logic here, because the lines from 435 to 453 were inside the if [ -f "$INSTALL_SRC_DIR/files/recovery.img" ] block, which is imho not correct. Forgot to mention it in the pr.

@drieschel

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2016

I can rebase the commits before the pr gets merged. I only wanted to show that I canged something in the meantime.

@chewitt

This comment has been minimized.

Copy link
Member

commented Aug 15, 2016

@drieschel tests okay on a variety of builds for me - please squash for merge

@drieschel drieschel force-pushed the drieschel:image-script branch from cdb1303 to 63ad4b9 Aug 15, 2016

@drieschel

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2016

@chewitt Done

@drieschel drieschel force-pushed the drieschel:image-script branch from 63ad4b9 to e0bdb4a Aug 15, 2016

@chewitt chewitt merged commit 44a05fd into LibreELEC:master Aug 15, 2016

@chewitt

This comment has been minimized.

Copy link
Member

commented Aug 15, 2016

thanks, that issue has been bugging me for a while :)

@drieschel

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2016

Don't mention it. :)

@drieschel drieschel deleted the drieschel:image-script branch Aug 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.