Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kodi: Temporarily revert PR10247 for Kodi 17 beta1 due to OOM #683

Merged
merged 1 commit into from Aug 31, 2016

Conversation

@MilhouseVH
Copy link
Contributor

commented Aug 31, 2016

See xbmc/xbmc#10247

@FernetMenta is on holiday and with the imminent release of 7.90.005 it would be better to revert PR10247. There is a partial fix, xbmc/xbmc#10367, however seeking remains a bit off in which case from the user experience point of view reverting the entire change is best.

The OOM issue will no doubt be fixed (in Kodi 17 Beta2) once fernet returns from holiday in which case this can be dropped from 7.90.006/LE8b1.

Close if not wanted.

@chewitt chewitt merged commit ec9cf07 into LibreELEC:master Aug 31, 2016
@FernetMenta

This comment has been minimized.

Copy link

commented Aug 31, 2016

you know that you broke TrueHD by this revert, don't you?

@MilhouseVH

This comment has been minimized.

Copy link
Contributor Author

commented Aug 31, 2016

There's no good solution right now, they all have downsides to varying degrees. I guess losing TrueHD is the least worst option. If anyone disagrees we can revert this.

@FernetMenta

This comment has been minimized.

Copy link

commented Aug 31, 2016

what is the remaining issue?

@MilhouseVH

This comment has been minimized.

Copy link
Contributor Author

commented Aug 31, 2016

After reverting the OOM leak, seeking is very hit and miss - sometimes it will work, but most times it will just freeze playback (though the GUI isn't frozen so playback can be ended). Playback often fails to end at the end of the video, so the user has to press STOP.

With PR10247 reverted, there is no OOM issue, and no problem seeking.

@FernetMenta

This comment has been minimized.

Copy link

commented Sep 1, 2016

After reverting the OOM leak

^^ please elaborate on this. how do you revert "the OOM leak"?

@MilhouseVH

This comment has been minimized.

Copy link
Contributor Author

commented Sep 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.