Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packages/linux: Correctly copy Amlogic device tree binary #697

Merged
merged 1 commit into from Sep 8, 2016

Conversation

@vpeter4
Copy link
Contributor

commented Sep 5, 2016

imx6 project has multiple device trees defined with KERNEL_UBOOT_EXTRA_TARGET

@CvH CvH added the BUILDSYSTEM label Sep 5, 2016
@lrusak

This comment has been minimized.

Copy link
Member

commented Sep 5, 2016

I don't understand, checking the directory seems redundant

@vpeter4

This comment has been minimized.

Copy link
Contributor Author

commented Sep 5, 2016

That's true. But maybe KERNEL_UBOOT_EXTRA_TARGET can be very large and test for a file could fail again.
But I can remove it if you want.

@stefansaraev

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2016

this PR is ok. warpping the file name you check for existence in quotes is always good. KERNEL_UBOOT_EXTRA_TARGET is not guaranteed to be a single word without spaces (or special chars. also see wetek core project)

@vpeter4

This comment has been minimized.

Copy link
Contributor Author

commented Sep 5, 2016

True, WeTek_Core also have two files defined which means whole cp line would fail too.

@codesnake: can you look this again? Because it doesn't work as you designed.

@stefansaraev

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2016

wetek core does not need dtb.img. before and after this PR, none is copied. I just pointed wetek core project as an example :)

@codesnake

This comment has been minimized.

Copy link
Member

commented Sep 5, 2016

Yes, this is correct solution, KERNEL_UBOOT_EXTRA_TARGET may contain several targets. But separate device tree binary is only required for WeTek Hub, WeTek Play and WeTek Core use device tree packed with kernel image.

imx6 project has multiple device trees defined with KERNEL_UBOOT_EXTRA_TARGET
@vpeter4 vpeter4 force-pushed the vpeter4:linux-fix branch from e95d0f0 to 6c88c9e Sep 7, 2016
@vpeter4

This comment has been minimized.

Copy link
Contributor Author

commented Sep 7, 2016

Added quotes in cp line too.

@chewitt chewitt merged commit 035b2a8 into LibreELEC:master Sep 8, 2016
@vpeter4 vpeter4 deleted the vpeter4:linux-fix branch Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.