Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toolchain: only setup_toolchain target when building #780

Merged
merged 1 commit into from Sep 30, 2016

Conversation

@MilhouseVH
Copy link
Contributor

commented Sep 30, 2016

Calling setup_toolchain target from path results in $ROOT/$TOOLCHAIN/etc/cmake-$TARGET_NAME.conf being written the first time options is sourced, which may happen when a build isn't taking place, or before all build variables are defined (eg. BUILD_SUFFIX, which causes the conf to be written into the wrong build directory).

With this change we only call setup_toolchain target when actually building, by which time all variables needed should be correctly setup.

Also, this should be more efficient, as options is sourced thousands of times during a build.

@MilhouseVH MilhouseVH force-pushed the MilhouseVH:toolchain_build branch from dd74b11 to af50108 Sep 30, 2016
@lrusak lrusak merged commit c230bc0 into LibreELEC:master Sep 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.