Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts/build: use MinSizeRel cmake build type #792

Merged
merged 3 commits into from Oct 13, 2016

Conversation

@lrusak
Copy link
Member

commented Oct 1, 2016

This builds with -Os instead of -O3/-O2

@stefansaraev

This comment has been minimized.

Copy link
Contributor

commented Oct 2, 2016

from cmake docs - release is default if not specified otherwise. MinSizeRel (whenever used at all) doesnt give you much saving imo.

@hudokkow

This comment has been minimized.

Copy link
Contributor

commented Oct 2, 2016

Also make sure binaries are being stripped. xbmc/xbmc#10595
I assumed -DCMAKE_BUILD_TYPE=Release stripped by default and it doesn't.

@stefansaraev

This comment has been minimized.

Copy link
Contributor

commented Oct 2, 2016

ouch. I assumed something like https://github.com/stefansaraev/TB/blob/master/scripts/build#L169-L171 is already in LE. but it is not...

EDIT: sorry for the noise. LE does strip. just a little bit different.

@lrusak

This comment has been minimized.

Copy link
Member Author

commented Oct 2, 2016

@stefansaraev either you can PR it or I can for you ;)

@lrusak

This comment has been minimized.

Copy link
Member Author

commented Oct 3, 2016

pushed some commits so that CMAKE_BUILD_TYPE isn't defined in the package.mk

@lrusak

This comment has been minimized.

Copy link
Member Author

commented Oct 5, 2016

any objections? @MilhouseVH what's your verdict?

@lrusak lrusak force-pushed the lrusak:cmake-fixups branch from 6e220ff to d7c99c3 Oct 5, 2016

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Oct 5, 2016

I'll need to re-try DEBUG=yes builds as it was failing on MySQL. Will give it a go overnight.

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Oct 6, 2016

Unfortunately this still fails to build MySQL with DEBUG=yes - tail end of build log: http://sprunge.us/KQBc. It's the same failure on RPi and RPi2. With DEBUG=no MySQL builds OK.

@lrusak

This comment has been minimized.

Copy link
Member Author

commented Oct 6, 2016

@MilhouseVH can I see the CMakeCache.txt for mysql?

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Oct 6, 2016

cat ./.x86_64-linux-gnu/CMakeCache.txt | pastebinit
http://sprunge.us/VGCS

cat ./.x86_64-libreelec-linux-gnu/CMakeCache.txt | pastebinit
http://sprunge.us/EhUX

@lrusak

This comment has been minimized.

Copy link
Member Author

commented Oct 6, 2016

thanks can you try adding -Wno-maybe-uninitialized to the CFLAGS and CXXFLAGS

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Oct 6, 2016

I tried: http://sprunge.us/dRYG which created http://sprunge.us/KJCg but still have the same build error.

Perhaps I messed up the change, did you have something else in mind? If so can you provide a patch? Thanks.

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Oct 11, 2016

@lrusak: any further ideas? I've hit a crash that would benefit from a debug build, so not being able to create them is a bit of an issue now. Alternative is to stop testing this PR...

lrusak added 3 commits Oct 13, 2016

@lrusak lrusak force-pushed the lrusak:cmake-fixups branch from d7c99c3 to ac9df97 Oct 13, 2016

@lrusak

This comment has been minimized.

Copy link
Member Author

commented Oct 13, 2016

dropped the mysql commit for now. This should be able to be merged now.

I'll look into the issue soon.

@MilhouseVH MilhouseVH merged commit d3293c9 into LibreELEC:master Oct 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.