Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tvheadend42: wizard fix + general config updates #814

Merged
merged 1 commit into from Oct 8, 2016

Conversation

@Glenn-1990
Copy link
Contributor

commented Oct 7, 2016

@CvH I'm pinging you as you seems to be the maintainer ;-)

It seems that the default configs are a bit outdated and can cause issues with non advanced users and SMB shares. Also the wizard on the first setup isn't working because of the predefined config. A big complain about tvheadend is that's it's hard to configure. My aim is to keep things simple, the user should be able to watch TV after running the wizard and enabling pvr.hts.

General config:

  • Use "basic" interface level, this is the default when installing tvheadend on other systems and it should be comparable to what regular STB's offer.
  • Disable the switch interface level button to avoid user confusion.
  • Enable the wizard on the first start. This is the default when installing tvheadend on other systems.
    -> it will guide the user trough a tuner setup, scan, and channel mapping (everything a basic users needs)
  • Fix picon path

DVR config:

  • Retention of 31 days is bad as recordings will disappear from Kodi after this period (while the files stay on disk). -> Use "on file removal" (INT_MAX-1) as retention to list all recordings in kodi that are actually available on the disk.
  • Booleaans should be 'true' or 'false'
  • Recordings are shared over SMB by libreelec but this has some issues:
  1. Recording names are meaningless (bones-1, bones-2,bones-3, etc), it's better to include channel, date-time and episode (for show scrapers). In this way the user can find back the recording he wants.

  2. Group recordings in Kodi isn't working because recordings are not grouped on the file system. Subdirectory's based on title will make this option working and will give the user a better overview when opening the SMB share.

  3. As we use SMB shares, we should use windows compatible filenames or we will end up with issues like this:
    http://forum.kodi.tv/showthread.php?tid=217071

EPG config:

  • Enable OTA grabbers by default, the user should get epg data after setting up channels. (like a regular STB), this is also the default by tvheadend.

Also a small question: is there a reason why "channel_rename" is enabled?

@chewitt

This comment has been minimized.

Copy link
Member

commented Oct 7, 2016

@Glenn-1990 can you please reword the commits as "tvheadend42: " so we know which package they belong to when scan-reading long lists of commits. At some point some poor sucker (usually me) has to absorb them into release notes. Thanks :)

"uilevel": 1,
"uilevel_nochange": false,
"wizard": "hello",
"uilevel": 0,

This comment has been minimized.

Copy link
@CvH

CvH Oct 7, 2016

Member

The main problem is that the users don't understand the view levels (or didn't know that they exist) so I'd like to keep the advanced level that at least basic configuration is possible (also a lot/all tuts are on base of expert or 4.0 - so if you have no idea that view levels are existing and 4/5 of the configs from the tutorial are not there isn't that helpful).
The uilevel_nochange": true would also prohibit that users can change that easily. I don't know the real perfect setting here, but from feedback the current setting is "okayish" (ofc it didn't fit to everyone).
pls change back to uilevel": 1

This comment has been minimized.

Copy link
@Glenn-1990

Glenn-1990 Oct 7, 2016

Author Contributor

Ok, no problem. I'm using the advanced level btw. ;-)

@@ -1,13 +1,14 @@
{
"uilevel": 1,
"uilevel_nochange": false,
"wizard": "hello",

This comment has been minimized.

Copy link
@CvH

CvH Oct 7, 2016

Member

great didn't found the value for this 👍

"uilevel_nochange": false,
"wizard": "hello",
"uilevel": 0,
"uilevel_nochange": true,

This comment has been minimized.

Copy link
@CvH

CvH Oct 7, 2016

Member

👍

"ui_quicktips": true,
"cookie_expires": 14,
"caclient_ui": true,
"epg_compress": true,
"prefer_picon": true,
"chiconpath": "file:///storage/picons/tvh/%C.png",
"chiconscheme": 2,
"piconpath": "file:///storage/picons/vdr/",
"piconpath": "file:///storage/picons/tvh/",
"piconscheme": 1

This comment has been minimized.

Copy link
@CvH

CvH Oct 7, 2016

Member

This isn't a bug, chiconpath are snp picons that are only supported from tvh, and piconpath are srp picons that are supported from vdr and tvh. The basic idea is that via an addon snp/srp picons coudl be installed and automatically could be used from tvh/vdr (currently kodi has an bug in the addon system which make this impossible).

This comment has been minimized.

Copy link
@Glenn-1990

Glenn-1990 Oct 7, 2016

Author Contributor

An addon would be would be handy indeed :-) Is the subdir actually needed, it's confusing that tvh users should put their picons in the vdr folder? Or should that addon be usable soon?

This comment has been minimized.

Copy link
@CvH

CvH Oct 7, 2016

Member

This wasn't planed this way, at addon dev we "found" this nice bug we are not able to probably work around (only 2-3 file/sec get extracted regardless of size and storage speed). Atm no proper solution at the horizon and for now just remain it as we have it. Or do you have an better idea ?

This comment has been minimized.

Copy link
@Glenn-1990

Glenn-1990 Oct 8, 2016

Author Contributor

Not really, is a test version of this addon available somewhere?

"episode-in-title": true,
"tag-files": true,
"windows-compatible-filenames": true,
"charset": "UTF-8"

This comment has been minimized.

Copy link
@CvH

CvH Oct 7, 2016

Member

the current settings are just Tvh defaults, tx for some better one 👍

"type": "Over-the-air",
"enabled": true,
"priority": 5
},

This comment has been minimized.

Copy link
@CvH

CvH Oct 7, 2016

Member

I have no real opinion about this, if this has no drawbacks for users which only use eit or xml this is okay.

This comment has been minimized.

Copy link
@Glenn-1990

Glenn-1990 Oct 7, 2016

Author Contributor

I'ts the default by tvh, so it should be save (and I'm using that for years):
https://github.com/tvheadend/tvheadend/blob/master/src/epggrab.c#L175

We could also remove the config and use tvheadends defaults? We will lose the periodic save and channel rename.

Btw: on 4.0, periodic save causes glitches in the livestreams/recordings when saving. Don't know if that's fixed.

This comment has been minimized.

Copy link
@CvH

CvH Oct 7, 2016

Member

Never heard of that in 4.1, lets see if this is an problem :D
Periodic save is essential for not server devices which eventually didn't shut down properly.

@Glenn-1990 Glenn-1990 force-pushed the Glenn-1990:tvheadend branch from f4cf755 to d80fd75 Oct 7, 2016
@Glenn-1990

This comment has been minimized.

Copy link
Contributor Author

commented Oct 8, 2016

@CvH @chewitt Commits updated

@CvH
CvH approved these changes Oct 8, 2016
@CvH

This comment has been minimized.

Copy link
Member

commented Oct 8, 2016

@Glenn-1990 tx, could you squash to one commit ?

@Glenn-1990 Glenn-1990 force-pushed the Glenn-1990:tvheadend branch from d80fd75 to ed438d9 Oct 8, 2016
@Glenn-1990

This comment has been minimized.

Copy link
Contributor Author

commented Oct 8, 2016

@CvH one commit now ;-)

@CvH CvH merged commit 5d0b534 into LibreELEC:master Oct 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.