Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add $DEVICE support to the build-system #842

Merged
merged 6 commits into from Nov 2, 2016

Conversation

@kszaq
Copy link
Contributor

commented Oct 15, 2016

Such projects should be compiled differently for each device.
A device for multi-device projects must be specified in the
command line.

Originally created by @codesnake: codesnake/OpenELEC.tv@7671253

Adapted for LE, I hope I got it all. Comments are very welcome.

Submitted per request from @chewitt

@codesnake

This comment has been minimized.

Copy link
Member

commented Oct 15, 2016

Thanks @kszaq. It is not the best solution, but I think is better than having a lot of similar projects with the same patches (especially for the Amlogic-based zoo). Makes maintenance easier for similar projects.

@kszaq kszaq force-pushed the kszaq:device_support branch from 63ca01d to 9a58471 Oct 15, 2016
@kszaq

This comment has been minimized.

Copy link
Contributor Author

commented Oct 15, 2016

I reworded commit message so that you don't get an email every time someone cherry-picks it in the future.

@Kwiboo

This comment has been minimized.

Copy link
Member

commented Oct 15, 2016

Will there ever be a project with mixed arch devices? If so I would suggest squashing Kwiboo@a8211b7 into this PR.

@Kwiboo

This comment has been minimized.

Copy link
Member

commented Oct 15, 2016

I have added some more commits to my pr842 branch that should enhance the device support, feel free to pick and squash anything that makes sense to include.

I skipped the following packages/files as it did not make much sense to have device specific versions:
xorg.conf
busybox-target.conf/busybox-init.conf
smb.conf
splash.conf/splash-*.png

@lrusak

This comment has been minimized.

Copy link
Member

commented Oct 16, 2016

I do not like having packages exist outside of $ROOT/packages/ I would like to clean up the fact that we currently allow $PROJECT/packages

Please if there is a way to avoid this please do it. There is no sense maintaining multiples of the same packages when you can just add a different PKG_VERSION to the package.mk

@vpeter4

This comment has been minimized.

Copy link
Contributor

commented Oct 16, 2016

Please leave package existence in project folder at least how it is done now. No need to remove this part of the code!

@chewitt chewitt changed the title Add a possibility to create the projects that could have several different devices Add $DEVICE support to the build-system Oct 16, 2016
@kszaq

This comment has been minimized.

Copy link
Contributor Author

commented Oct 18, 2016

@Kwiboo Thank you, your commits are for sure a necessary addition here. I will pick them to this PR.

@lrusak I can remove device-specific packages from this PR while not changing project-specific packages. What do you think?

@lrusak

This comment has been minimized.

Copy link
Member

commented Oct 18, 2016

@kszaq Yes that would be preferred, thanks.

@kszaq kszaq force-pushed the kszaq:device_support branch from 9a58471 to 4cc089e Oct 18, 2016
@kszaq

This comment has been minimized.

Copy link
Contributor Author

commented Oct 18, 2016

PR Updated:

  • removed device-specific packages, while keeping device-specific patches
  • improved $DEVICE support patches from @Kwiboo for features that I missed
@Kwiboo

This comment has been minimized.

Copy link
Member

commented Oct 18, 2016

@kszaq the scripts/image: bootloader device support commit needs to be updated to remove the BOOTLOADER_DIR modifications now that device-specific packages is removed, other then that it looks great

@kszaq kszaq force-pushed the kszaq:device_support branch from 4cc089e to e24beb3 Oct 18, 2016
@kszaq

This comment has been minimized.

Copy link
Contributor Author

commented Oct 18, 2016

@Kwiboo thank you once again! Updated.

@lrusak

This comment has been minimized.

Copy link
Member

commented Oct 19, 2016

I'm happy with this 👍 thanks @kszaq and @Kwiboo

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Oct 19, 2016

One downside of this is that the PRETTY_NAME shown in Kodi Sys Info, and LE Settings > About may become illegible due to increased length, particularly for custom builds (actually for custom builds these labels are shady pretty useless, with the addition of $DEVICE they'll just become even more so). Perhaps we need to think of a more useful PRETTY NAME that doesn't include the kitchen sink. This is cosmetic, and could be left for a separate PR, you'll see the problem more clearly once this goes in.

@chewitt

This comment has been minimized.

Copy link
Member

commented Oct 21, 2016

I'm expecting Kodi 17b4 to land fairly soon, so I plan to merge this PR after we ship v7.90.008

@kszaq kszaq force-pushed the kszaq:device_support branch from e24beb3 to 5bc7ac7 Oct 28, 2016
@chewitt chewitt merged commit 7de58ac into LibreELEC:master Nov 2, 2016
@kszaq kszaq deleted the kszaq:device_support branch Nov 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.