Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nano: cleanup #877

Merged
merged 2 commits into from Nov 4, 2016

Conversation

@InuSasha
Copy link
Member

commented Oct 24, 2016

No description provided.

@stefansaraev

This comment has been minimized.

Copy link
Contributor

commented Oct 24, 2016

zlib is only needed when built with --enable-libmagic

it should be safe to remove export LIBS="$LIBS -lz" instead

@stefansaraev

This comment has been minimized.

Copy link
Contributor

commented Oct 24, 2016

unrelated to this PR, but not stripping -Wl,--as-needed from LDFLAGS should also be safe. pre_configure_target() can go.

@InuSasha

This comment has been minimized.

Copy link
Member Author

commented Oct 24, 2016

Ok, this is a solution too.
Make a clean build without the LIBS export of nano.

@stefansaraev

This comment has been minimized.

Copy link
Contributor

commented Oct 24, 2016

no need for clean build. just remove LIBS=, rebuild nano and check library dependencies:

build.*/toolchain/bin/*-readelf -d build.*/nano-*/.build_*/src/nano

sorta, if libz.so is not listed as NEEDED. you are good.

@InuSasha InuSasha force-pushed the InuSasha:fixes/nano branch from a8ea552 to d0bb5fc Oct 24, 2016
@InuSasha

This comment has been minimized.

Copy link
Member Author

commented Oct 24, 2016

switched to @stefansaraev solution.
build was fine, without zlib

builds fine, without the strip of "-Wl,--as-needed".
Should i add it, to this pr, or make another one?

@stefansaraev

This comment has been minimized.

Copy link
Contributor

commented Oct 24, 2016

as you wish, you can add it, but it would need build testing for all supported project/archs

@InuSasha

This comment has been minimized.

Copy link
Member Author

commented Oct 24, 2016

will add it, after build test

@InuSasha

This comment has been minimized.

Copy link
Member Author

commented Oct 25, 2016

nano builds fine, in all project without "stip of -Wl,-as-needed"

@InuSasha InuSasha force-pushed the InuSasha:fixes/nano branch from 42f6ff5 to 9a35e85 Oct 25, 2016
@lrusak lrusak changed the title nano: depends on zlib nano: cleanup Oct 25, 2016
@lrusak lrusak added the Cleanup label Oct 25, 2016
@lrusak lrusak merged commit 7c8944f into LibreELEC:master Nov 4, 2016
@InuSasha InuSasha deleted the InuSasha:fixes/nano branch Nov 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.