Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obround footprint pads might have wrong orientation #424

Closed
ubruhin opened this issue Mar 4, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@ubruhin
Copy link
Member

commented Mar 4, 2019

VERSION / OS / ENVIRONMENT
LibrePCB Version: 0.1.0
Git Revision:     d7458d3b3e126499902e1a66a0ef889f516a7c97
Build Date:       2018-11-24T16:25:35
Qt Version:       5.9.1 (built against 5.9.1)
CPU Architecture: x86_64
Operating System: Ubuntu 14.04.6 LTS
Platform Plugin:  xcb
SUMMARY

Obround footprint pads keep their orientation even after swapping width and height.

STEPS TO REPRODUCE
  • Create an obround pad in the package editor with size 2x3mm
  • Change size to 3x2mm
EXPECTED RESULTS

The pad should be rendered differently (90° rotated) after swapping width and height.

ACTUAL RESULTS

The pad is rendered the same as before swapping width and height.

ADDITIONAL INFORMATION

The root cause seems to be a bug in Path::obround(). We should check if there are even more things going wrong, or if only obround footprint pads are affected.

I'm not sure if we can fix this bug without breaking existing packages and projects. If it breaks something, I think we shouldn't fix the bug in the 0.1.1 release but wait until the 0.2.0 release (which will introduce a new file format anyway and thus we can perform a backwards compatible upgrade).

@ubruhin ubruhin added the bug label Mar 4, 2019

@ubruhin ubruhin added this to the 0.2.0 milestone Mar 4, 2019

@ubruhin ubruhin moved this from Planned to Done in Improve user experience of GUI Mar 11, 2019

@ubruhin ubruhin self-assigned this Mar 12, 2019

@ubruhin

This comment has been minimized.

Copy link
Member Author

commented Mar 14, 2019

I checked this now, and it turned out that the Gerber output was not affected by this bug, so "only" the editors have shown the wrong orientation. Which does not mean this bug is not critical (inconsistencies between editor view and Gerber output are always critical bugs), but due to this fact we can't fix it in a backward compatible manner anyway, thus I think we should fix it in the 0.1.1 release.

Fortunately none of the packages in our official libraries are affected by this bug ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.