Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manufacturer name field to library elements #653

Open
dbrgn opened this issue Jan 9, 2020 · 3 comments
Open

Add manufacturer name field to library elements #653

dbrgn opened this issue Jan 9, 2020 · 3 comments

Comments

@dbrgn
Copy link
Member

@dbrgn dbrgn commented Jan 9, 2020

SUMMARY

As discussed in https://librepcb.discourse.group/t/naming-of-packages/167/, the manufacturer field could be included in the library file format for the following entities:

  • Symbol
  • Component
  • Package
  • Device
SOLUTION
  • The field should be optional
  • This requires a file format change, so it should probably be part of the v0.2 release
  • The field can be used for filtering (e.g. in the "add component" dialog), but it should probably not be shown in the schematics or board editor by default
@dbrgn dbrgn added this to the 0.2.0 milestone Jan 9, 2020
@EdizonTN

This comment has been minimized.

Copy link

@EdizonTN EdizonTN commented Jan 10, 2020

If you adding a new field, can you add also some else?
For example, for device:
Component

@dbrgn

This comment has been minimized.

Copy link
Member Author

@dbrgn dbrgn commented Jan 12, 2020

While manufacturer name is relevant for the LibrePCB UI itself, I wonder if we could allow arbitrary attributes in the devices, which would act as predefined attributes in the schematics. For example, the manufacturer name could be automatically set as MANUFACTURER attribute. A LED device could predefine set the FORWARD_VOLTAGE attribute. In the schematics, the user can then always overwrite those attributes if desired.

Order number management could also use this system, some of the attributes like MPN or DIGIKEY would then be filled in depending on the device variant chosen.

But that's probably a separate feature.

@EdizonTN

This comment has been minimized.

Copy link

@EdizonTN EdizonTN commented Jan 12, 2020

Yes, you true. Its a separate feature.
Have you deadline for v0.2.0 (change file format)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.