Bundle fonts used in schematics together with LibrePCB #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can the bundled fonts be easily replaced with system fonts during packaging? |
Yeah, actually one can just remove the fonts directory, then Qt automatically falls back to system fonts (fonts are recognized by their name, no matter if they are system fonts or bundled fonts). |
rnestler
reviewed
Jun 27, 2018
| font.setStyleStrategy(QFont::StyleStrategy(QFont::OpenGLCompatible | QFont::PreferQuality)); | ||
| font.setStyleHint(QFont::TypeWriter); | ||
| font.setFamily("Monospace"); | ||
| QFont font = qApp->getDefaultMonospaceFont(); |
There was a problem hiding this comment.
So Qt prefers the bundled fonts?
There was a problem hiding this comment.
Ah I just noticed that we provide this method ourself.
There was a problem hiding this comment.
Right :) Qt itself doesn't really distinguish between bundled or system fonts...
Offset no longer required due to new fonts.
ubruhin
force-pushed
the
153-bundle-schematic-fonts
branch
from
77e8d3e
to
fb429c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes LibrePCB using Noto Fonts for schematics. To ensure consistent look over all platforms, the fonts are bundled together with LibrePCB. So the look of schematics no longer depends on the available system fonts.
Preview:
Fixes #153.