New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deselecting items while keeping other items selected #361

Merged
merged 4 commits into from Oct 28, 2018

Conversation

2 participants
@jameshclrk
Contributor

jameshclrk commented Oct 27, 2018

Fixes #350

@ubruhin

This comment has been minimized.

Member

ubruhin commented Oct 27, 2018

Nice! 😃

I quickly tried it. Toggle item selection works, but unfortunately now it's no longer possible to move all selected items together (selection gets cleared when start dragging). I hope you can fix that :)

@jameshclrk jameshclrk force-pushed the jameshclrk:ctrl_deselect branch from 2ae52f2 to f699217 Oct 27, 2018

@jameshclrk

This comment has been minimized.

Contributor

jameshclrk commented Oct 27, 2018

I've rebased with a new approach, I think this addresses the moving of selected items :)

@ubruhin

This comment has been minimized.

Member

ubruhin commented Oct 28, 2018

Perfect, seems to work now :)

Thanks for your contribution!

@ubruhin ubruhin merged commit 26340c3 into LibrePCB:master Oct 28, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ubruhin ubruhin moved this from In Progress to Done in Improve user experience of GUI Oct 28, 2018

ubruhin added a commit that referenced this pull request Nov 3, 2018

Merge pull request #361 from jameshclrk/ctrl_deselect
Allow deselecting items while keeping other items selected
(cherry picked from commit 26340c3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment