Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibraryEditor: Support undo/redo also for library element metadata #375

Merged
merged 7 commits into from Nov 14, 2018

Conversation

1 participant
@ubruhin
Copy link
Member

commented Nov 12, 2018

Until now, library element metadata was not tracked with the undo system. Now every change of every library element metadata is added to the undo stack and thus can be undone/redone.

This is needed for my next pull request 馃榿

@ubruhin ubruhin added the enhancement label Nov 12, 2018

ubruhin added some commits Nov 11, 2018

UndoCommandGroup: Properly report if something has changed
The method performExecute() did not return "false" if nothing was
changed. In some cases this ended up in undo commands on the undo stack
which did not modify anything. Now such "empty" undo commands will not
be added to the undo stack at all.
Library: Properly handle changing of library icon
Storing it as QByteArray allows to properly load/change/save the icon,
similar to all other properties of a library element.

@ubruhin ubruhin force-pushed the library-editor-undo branch from 137d66e to 868350e Nov 13, 2018

@ubruhin ubruhin merged commit a2152fe into master Nov 14, 2018

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ubruhin ubruhin deleted the library-editor-undo branch Nov 14, 2018

@ubruhin ubruhin added this to the 0.1.1 milestone Nov 24, 2018

ubruhin added a commit that referenced this pull request Mar 17, 2019

Merge pull request #375 from LibrePCB/library-editor-undo
LibraryEditor: Support undo/redo also for library element metadata
(cherry picked from commit a2152fe)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.