Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Add library element context menu #380
Add context menu entry for removing the currently selected element.
@ubruhin this is a first draft. Is the way I approached the issue correct? If yes, I can add support for the other library elements.
This could also be extended later on, e.g. when right-clicking on the empty space of the symbol list widget, we could add an entry called "Create symbol". When right-clicking on an existing symbol, we could add an entry called "Create symbol from this symbol" or something like that.
I think once this is in place, we can actually remove the delete menu entries, I think they're bad UX because it's not clear what they're referring to.
Looks not bad so far
Would be nice if you could do it in this PR :)
@ubruhin do you know how to prevent the following bug?
For some reason, the selection is not updated sometimes when right-clicking on another item while the context menu for the first item is still open.
Regarding closing the tab if it's open:
I removed the remove action in the file menu, it's now replaced with the context menu. However, regarding the disabling of the delete/rotate items in the edit menu and toolbar, I think that's complex enough that it should be done in a separate PR. It doesn't have anything to do with removing library elements.
referenced this pull request
Nov 29, 2018
ubruhin left a comment
See comments. In addition, the branch should be rebased.
Btw, it would be very nice to also support the "delete" keyboard shortcut to remove the currently selected item, although it's not required to get this merged :)