Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tabs closable with middle mouse button #388

Merged
merged 2 commits into from Dec 10, 2018

Conversation

Projects
None yet
2 participants
@dbrgn
Copy link
Member

commented Dec 8, 2018

This has bugged me for a while 馃檪

Code is loosely based on https://github.com/mbunkus/mkvtoolnix/commit/4c05f4263372153539535bd6bd401045c8f2ed61.

@dbrgn dbrgn requested a review from ubruhin Dec 8, 2018

@dbrgn dbrgn changed the title LibraryEditor: Make tabs closable with middle mouse button LibraryEditor: Make tabs closable with middle mouse btn Dec 8, 2018

@dbrgn dbrgn changed the title LibraryEditor: Make tabs closable with middle mouse btn Make tabs closable with middle mouse button Dec 8, 2018

@dbrgn dbrgn force-pushed the close-tabs-middle-mouse-button branch from 85b9a40 to 8c20c62 Dec 9, 2018

@dbrgn

This comment has been minimized.

Copy link
Member Author

commented Dec 9, 2018

Rebased and reformatted.

@ubruhin
Copy link
Member

left a comment

Works great, but still requires some code adjustments :)

Show resolved Hide resolved libs/librepcb/common/widgets/tabwidget.cpp Outdated
Show resolved Hide resolved libs/librepcb/common/widgets/tabwidget.cpp
Show resolved Hide resolved libs/librepcb/common/widgets/tabwidget.cpp
Show resolved Hide resolved libs/librepcb/common/widgets/tabwidget.cpp Outdated
Show resolved Hide resolved libs/librepcb/common/widgets/tabwidget.cpp Outdated
Show resolved Hide resolved libs/librepcb/common/widgets/tabwidget.cpp Outdated
Show resolved Hide resolved libs/librepcb/common/widgets/tabwidget.h Outdated
Show resolved Hide resolved libs/librepcb/common/widgets/tabwidget.h Outdated
@ubruhin

This comment has been minimized.

Copy link
Member

commented Dec 9, 2018

Hmm my review seems to be based on an older revision, although I started a new review after you pushed :( Maybe you need to run clang-format again after applying the suggestions ;)

EDIT: Ah, it seems that two reviews are combined into one...

@dbrgn

This comment has been minimized.

Copy link
Member Author

commented Dec 9, 2018

Implemented requested changes.

@dbrgn dbrgn force-pushed the close-tabs-middle-mouse-button branch 2 times, most recently from 1319bba to 82bdfae Dec 9, 2018

@dbrgn dbrgn force-pushed the close-tabs-middle-mouse-button branch from 82bdfae to 72180c7 Dec 9, 2018

@ubruhin

ubruhin approved these changes Dec 9, 2018

@dbrgn

This comment has been minimized.

Copy link
Member Author

commented Dec 9, 2018

@ubruhin you have to merge the PR yourself, I don't have the permission to do so 馃檪 (Or maybe I misunderstood your accept-without-merge?)

@ubruhin

This comment has been minimized.

Copy link
Member

commented Dec 10, 2018

@ubruhin you have to merge the PR yourself, I don't have the permission to do so slightly_smiling_face (Or maybe I misunderstood your accept-without-merge?)

I know, I just dismissed my previous review and then had to wait until CI succeeds :)

Thanks for the improvement!

@ubruhin ubruhin merged commit 1bedd9f into master Dec 10, 2018

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ubruhin ubruhin deleted the close-tabs-middle-mouse-button branch Dec 10, 2018

@dbrgn

This comment has been minimized.

Copy link
Member Author

commented Dec 10, 2018

Ah 馃檪

ubruhin added a commit that referenced this pull request Mar 17, 2019

Merge pull request #388 from LibrePCB/close-tabs-middle-mouse-button
Make tabs closable with middle mouse button
(cherry picked from commit 1bedd9f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.