Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library Editor: Fix possibly outdated information in component signal editor #398

Merged
merged 3 commits into from Dec 28, 2018

Conversation

Projects
None yet
2 participants
@picknick-
Copy link
Contributor

commented Dec 25, 2018

componentSignalListedEditorWidget: Fix wrong behaviour when name of
signal contains forbidden characters.

Updating signal table when name and name without forbidden characters are
the same.

Fixes #392

Michal Szulc
componentSignalListedEditorWidget: Fix wrong behauvior when name of s…
…ignal contains forbidden characters.

componentSignalListedEditorWidget: Fix wrong behauvior when name of
signal contains forbidden characters.

Updating signal table when name and name without foridden characters are
the same.

Fixes #392
@ubruhin

This comment has been minimized.

Copy link
Member

commented Dec 27, 2018

Thanks @picknick-!

Looks good so far. But there is still a case where the table is not updated properly: If you enter a signal name which already exists, a message box appears which says that the signal name is already used. After closing the message box, the table still contains the entered name instead of reverting to the old name. Would you give it a try to fix this too? :)

Michal Szulc
componentSignalListedEditorWidget:Fix wrong behaviour
componentSignalListedEditorWidget: Fix wrong behaviour when name of
already existing signal contains forbidden characters.

Updating signal table when other name and name without forbidden
characters are the same.
@picknick-

This comment has been minimized.

Copy link
Contributor Author

commented Dec 27, 2018

Sure, fixed in latest commit.

@ubruhin

This comment has been minimized.

Copy link
Member

commented Dec 27, 2018

Works great now :)

I just noticed that you used 4 spaces as indentation, but our coding style is to us only 2 spaces (you could use clang-format to automatically format the code, see details here - but in that simple case it's easy to do it by hand). If you fixed it, I think this is ready to merge. (Sorry, I didn't notice that style issue in my last review.)

@ubruhin ubruhin changed the title componentSignalListedEditorWidget: Fix wrong behauvior. Library Editor: Fix possibly outdated information in component signal editor Dec 27, 2018

@ubruhin

This comment has been minimized.

Copy link
Member

commented Dec 28, 2018

Thanks for updating! 😃

@ubruhin ubruhin merged commit 509acb2 into LibrePCB:master Dec 28, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

ubruhin added a commit that referenced this pull request Mar 17, 2019

Library Editor: Fix possibly outdated information in component signal…
… editor (#398)

ComponentSignalListEditorWidget: Fix wrong behavior when name of signal contains forbidden characters. Updating signal table when name and name without forbidden characters are
the same.
(cherry picked from commit 509acb2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.