Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library Editor: Display element name in "save" action #419

Merged
merged 1 commit into from Feb 14, 2019

Conversation

1 participant
@ubruhin
Copy link
Member

commented Feb 12, 2019

Instead of always naming the action "Save element", show the actual element name in the action's title, e.g. "Save 'NE555'".

This is the last change needed to close #384.

Fixes #384.

Library Editor: Display element name in "save" action
Instead of always naming the action "Save element", show the actual
element name in the action's title, e.g. "Save 'NE555'".

@ubruhin ubruhin added the UI / UX label Feb 12, 2019

@ubruhin ubruhin added this to the 0.1.1 milestone Feb 12, 2019

@ubruhin ubruhin merged commit a658856 into master Feb 14, 2019

2 of 4 checks passed

continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ubruhin ubruhin deleted the 384-rename-libraryeditor-save-action branch Feb 14, 2019

ubruhin added a commit that referenced this pull request Mar 17, 2019

Library Editor: Display element name in "save" action (#419)
Instead of always naming the action "Save element", show the actual
element name in the action's title, e.g. "Save 'NE555'".
(cherry picked from commit a658856)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.