Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library Editor: Extend functionality of overview lists #425

Merged
merged 7 commits into from Mar 10, 2019

Conversation

2 participants
@ubruhin
Copy link
Member

commented Mar 9, 2019

  • Allow multi selection in lists (to edit or remove multiple elements at once)
  • Enable "delete" shortcut to remove elements with the keyboard shortcut
  • Add new context menu items to the library editor overview tab:
    • "Edit": Same as double click
    • "Copy": To open the "New Library Element" dialog, prefilled with the values of the selected element (disabled if multiple elements are selected)
  • Add some more functional tests

grafik

Fixes #347

@ubruhin ubruhin added this to the 0.1.1 milestone Mar 9, 2019

@ubruhin ubruhin self-assigned this Mar 9, 2019

@ubruhin ubruhin added this to In Progress in Improve user experience of GUI Mar 9, 2019

@dbrgn

This comment has been minimized.

Copy link
Member

commented Mar 9, 2019

Awesome!

If you want to add another small improvement: Add an entry "Add" to the context menu when clicking on empty space in one of those lists.

image

@ubruhin ubruhin force-pushed the 347-library-editor-context-menu branch from be77ec3 to c8fb156 Mar 9, 2019

@ubruhin

This comment has been minimized.

Copy link
Member Author

commented Mar 9, 2019

Add an entry "Add" to the context menu when clicking on empty space in one of those lists.

Good point -> done 😃

But the menu item is also shown when clicking on an item, because in a full list it's not possible to click on empty space.

grafik

@ubruhin ubruhin changed the title Library Editor: Extend functionality of overview element lists Library Editor: Extend functionality of overview lists Mar 9, 2019

@dbrgn

This comment has been minimized.

Copy link
Member

commented Mar 9, 2019

But the menu item is also shown when clicking on an item, because in a full list it's not possible to click on empty space.

Good point 🙂

@ubruhin ubruhin merged commit 39d3dc5 into master Mar 10, 2019

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ubruhin ubruhin deleted the 347-library-editor-context-menu branch Mar 10, 2019

@ubruhin ubruhin moved this from In Progress to Done in Improve user experience of GUI Mar 11, 2019

ubruhin added a commit that referenced this pull request Mar 17, 2019

Merge pull request #425 from LibrePCB/347-library-editor-context-menu
Library Editor: Extend functionality of overview lists
(cherry picked from commit 39d3dc5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.