Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default layer colors #440

Merged
merged 4 commits into from Apr 19, 2019

Conversation

Projects
None yet
2 participants
@dbrgn
Copy link
Member

commented Apr 8, 2019

Still untested, I hope it compiles 馃檪

Fixes #406.

@dbrgn dbrgn added the enhancement label Apr 8, 2019

@dbrgn dbrgn requested a review from ubruhin Apr 8, 2019

@dbrgn

This comment has been minimized.

Copy link
Member Author

commented Apr 14, 2019

@ubruhin ping!

@ubruhin
Copy link
Member

left a comment

Thanks! I added a commit to slightly increase the difference between highlighted and non-highlighted colors. But after a final review, I still struggled with two layers, see comments below.

Show resolved Hide resolved libs/librepcb/common/graphics/graphicslayer.cpp Outdated
Show resolved Hide resolved libs/librepcb/common/graphics/graphicslayer.cpp Outdated
@ubruhin

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

@dbrgn What do you think about the two suggestions? Go or no-go? :)

@ubruhin ubruhin added this to the 0.1.1 milestone Apr 16, 2019

@ubruhin ubruhin merged commit bb028ae into master Apr 19, 2019

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ubruhin ubruhin deleted the 406-new-colors branch Apr 19, 2019

ubruhin added a commit that referenced this pull request Apr 19, 2019

Update default layer colors (#440)
(cherry picked from commit bb028ae)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.