Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search field to symbol/package/component chooser dialogs #443

Merged
merged 4 commits into from Apr 19, 2019

Conversation

2 participants
@ubruhin
Copy link
Member

commented Apr 17, 2019

In the library editor there are various locations where you need to choose a symbol, package or component with a dialog. This PR adds a search text field to these dialogs to help finding elements, basically just like we already have it in the "Add Component" dialog in the schematic editor.

grafik

@ubruhin ubruhin added this to the 0.1.1 milestone Apr 17, 2019

@ubruhin ubruhin self-assigned this Apr 17, 2019

@ubruhin ubruhin added this to In Progress in Improve user experience of GUI Apr 17, 2019

@dbrgn

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

Cool! Does this also fix the search itself?

@ubruhin

This comment has been minimized.

Copy link
Member Author

commented Apr 18, 2019

With "fix the search itself" you mean the "Add Component" dialog in the schematic editor with the not very powerful search? Then no, this PR has nothing to do with that search. The "Add component" dialog is more complex because it searches for components and devices, while the dialogs in the library editor only search one element type which works perfectly.

@ubruhin ubruhin force-pushed the library-dialogs-search-field branch from d387f43 to 5b0644e Apr 18, 2019

@ubruhin ubruhin merged commit c37f50f into master Apr 19, 2019

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ubruhin ubruhin deleted the library-dialogs-search-field branch Apr 19, 2019

@ubruhin ubruhin moved this from In Progress to Done in Improve user experience of GUI Apr 19, 2019

ubruhin added a commit that referenced this pull request Apr 19, 2019

Merge pull request #443 from LibrePCB/library-dialogs-search-field
Add search field to symbol/package/component chooser dialogs
(cherry picked from commit c37f50f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.