Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddComponentDialog: Refactor and improve search #444

Merged
merged 3 commits into from Apr 19, 2019

Conversation

1 participant
@ubruhin
Copy link
Member

commented Apr 19, 2019

Makes the search function in the "Add Component" dialog of the schematic editor much more powerful:

  • Also find components which do not have devices (previously such components were not found).
  • If the component doesn't match the search term:
    • Only show its devices which match the term (previously, all devices were shown).
    • Expand the tree item to directly show the matched devices (previously all tree items were collapsed)

@ubruhin ubruhin added this to the 0.1.1 milestone Apr 19, 2019

@ubruhin ubruhin self-assigned this Apr 19, 2019

ubruhin added some commits Apr 19, 2019

AddComponentDialog: Refactor and improve search
Makes the search function much more powerful:

- Also find components which do not have devices (previously such
  components were not found).
- If the component doesn't match the search term:
  - Only show its devices which match the term (previously, all devices
    were shown).
  - Expand the tree item to directly show the matched devices
    (previously all tree items were collapsed).

@ubruhin ubruhin force-pushed the improve-add-component-search branch from e6449ed to b54190b Apr 19, 2019

@ubruhin ubruhin added this to In Progress in Improve user experience of GUI Apr 19, 2019

@ubruhin ubruhin merged commit 2167f78 into master Apr 19, 2019

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ubruhin ubruhin deleted the improve-add-component-search branch Apr 19, 2019

ubruhin added a commit that referenced this pull request Apr 19, 2019

Merge pull request #444 from LibrePCB/improve-add-component-search
AddComponentDialog: Refactor and improve search
(cherry picked from commit 2167f78)

@ubruhin ubruhin moved this from In Progress to Done in Improve user experience of GUI May 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.