Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library editor overview: Rename "copy" to "duplicate" #447

Merged
merged 1 commit into from May 12, 2019
Merged

Conversation

@dbrgn
Copy link
Member

@dbrgn dbrgn commented May 9, 2019

The "copy" context menu action implies that there's a paste action.
However, there is no such thing. What really happens is a duplication, a
new library element is created from the current element.

@dbrgn dbrgn added the UI / UX label May 9, 2019
@dbrgn dbrgn requested a review from ubruhin May 9, 2019
The "copy" context menu action implies that there's a paste action.
However, there is no such thing. What really happens is a duplication, a
new library element is created from the current element.
@dbrgn dbrgn force-pushed the copy-to-duplicate branch from 15265b8 to cdd879c May 9, 2019
@dbrgn
Copy link
Member Author

@dbrgn dbrgn commented May 10, 2019

Not sure why the tests fail.

@ubruhin
Copy link
Member

@ubruhin ubruhin commented May 12, 2019

Not sure why the tests fail.

It's because of race conditions in Funq, see parkouss/funq#55 (comment) for details. This is really annoying :(

I restarted the jobs, hopefully they succeed now...

@ubruhin ubruhin added this to the 0.1.2 milestone May 12, 2019
@ubruhin ubruhin merged commit 541d293 into master May 12, 2019
4 checks passed
@ubruhin ubruhin deleted the copy-to-duplicate branch May 12, 2019
ubruhin added a commit that referenced this issue Jul 8, 2019
Library editor overview: Rename "copy" to "duplicate"
(cherry picked from commit 541d293)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants